Repository navigation
Harden two more load-sensitive tests - #136
Merged
Merged
Conversation
The drain-cancellation test raised a process-wide SIGINT. When the bounded run test installed its interrupt latch during that window, the signal reached the run latch instead: the process test waited for pipe EOF and the run test stopped before dispatch. Invoke the guard's handler directly; CLI tests still deliver real SIGINT/SIGTERM to the collector. The System One compare test assumed a 40 ms reference delay outlasts every candidate burst. Loaded hosts stretched candidate bursts past 1.4 s. Capture the candidate first and delay each reference request by its slowest retained burst, so the declared change holds by construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two more tests that failed only under heavy machine load. Both were test problems, not product bugs. Test-only change, apart from making one function visible to its test module.
process::tests::cancellation_interrupts_normal_exit_pipe_draincancelispub(super). Real signal delivery stays covered end to end byexternal_program_cancellation_cleans_only_owned_group, which signals a separate process.systemone_tests::compare_reports_a_declared_change_under_the_observed_envelopesparkdash_portable_copies…stayed green over 540 loaded runs plus injected delays, so it's left unchanged.Testing
cargo fmt --checkandcargo clippy --all-targets -- -D warnings.Performance claim
None.