Skip to content

ALPHARMSD, ANTIBETARMSD, PARABETARMSD: USEGPU also for DISTANCE and L… - #1640

Closed
carlocamilloni wants to merge 1 commit into
masterfrom
ss-gpu-chain
Closed

carlocamilloni wants to merge 1 commit into
masterfrom
ss-gpu-chain

Conversation

@carlocamilloni

Copy link
Copy Markdown
Member

…ESS_THAN

With USEGPU only SECONDARY_STRUCTURE_DRMSD ran on the GPU: the distances of STRANDS_CUTOFF and the switching functions (LESS_THAN, also with the mask) ran on the CPU, although the openaccPTM plugin provides DISTANCE_VECTORACC and LESS_THAN_VECTORACC. The shortcuts now pass USEGPU to them too. CUSTOM, LOWEST and SUM have no GPU version and stay on the CPU. Without USEGPU the expanded input is unchanged.

Tested with the plugin built with g++ and the host stub of the OpenACC runtime: the 47 targetGPU regtests pass (rt-GPU-secondarystructure and rt-GPU-secondarystructure-DRMSD now use DISTANCE_VECTORACC and LESS_THAN_VECTORACC); regtest/secondarystructure passes.

Claude-Session: https://claude.ai/code/session_016vwxtV46v5FLckcMEcJrbt

Description
Target release

I would like my code to appear in release XXXXX

Type of contribution
  • changes to code or doc authored by PLUMED developers, or additions of code in the core or within the default modules
  • changes to a module not authored by you
  • new module contribution or edit of a module authored by you
Copyright
  • I agree to transfer the copyright of the code I have written to the PLUMED developers or to the author of the code I am modifying.
  • the module I added or modified contains a COPYRIGHT file with the correct license information. Code should be released under an open source license. I also used the command cd src && ./header.sh mymodulename in order to make sure the headers of the module are correct.
Tests
  • I added a new regtest or modified an existing regtest to validate my changes.
  • I verified that all regtests are passed successfully on GitHub Actions.

…ESS_THAN

With USEGPU only SECONDARY_STRUCTURE_DRMSD ran on the GPU: the
distances of STRANDS_CUTOFF and the switching functions (LESS_THAN,
also with the mask) ran on the CPU, although the openaccPTM plugin
provides DISTANCE_VECTORACC and LESS_THAN_VECTORACC. The shortcuts now
pass USEGPU to them too. CUSTOM, LOWEST and SUM have no GPU version
and stay on the CPU. Without USEGPU the expanded input is unchanged.

Tested with the plugin built with g++ and the host stub of the
OpenACC runtime: the 47 targetGPU regtests pass (rt-GPU-secondarystructure
and rt-GPU-secondarystructure-DRMSD now use DISTANCE_VECTORACC and
LESS_THAN_VECTORACC); regtest/secondarystructure passes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016vwxtV46v5FLckcMEcJrbt
@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.97%. Comparing base (33b78e7) to head (a66a42e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
- Coverage   88.97%   88.97%   -0.01%     
==========================================
  Files         651      651              
  Lines       81815    81812       -3     
==========================================
- Hits        72793    72790       -3     
  Misses       9022     9022              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants