Repository navigation
ALPHARMSD, ANTIBETARMSD, PARABETARMSD: USEGPU also for DISTANCE and L… - #1640
Closed
carlocamilloni wants to merge 1 commit into
Closed
carlocamilloni wants to merge 1 commit into
carlocamilloni wants to merge 1 commit into
Conversation
…ESS_THAN With USEGPU only SECONDARY_STRUCTURE_DRMSD ran on the GPU: the distances of STRANDS_CUTOFF and the switching functions (LESS_THAN, also with the mask) ran on the CPU, although the openaccPTM plugin provides DISTANCE_VECTORACC and LESS_THAN_VECTORACC. The shortcuts now pass USEGPU to them too. CUSTOM, LOWEST and SUM have no GPU version and stay on the CPU. Without USEGPU the expanded input is unchanged. Tested with the plugin built with g++ and the host stub of the OpenACC runtime: the 47 targetGPU regtests pass (rt-GPU-secondarystructure and rt-GPU-secondarystructure-DRMSD now use DISTANCE_VECTORACC and LESS_THAN_VECTORACC); regtest/secondarystructure passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016vwxtV46v5FLckcMEcJrbt
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1640 +/- ##
==========================================
- Coverage 88.97% 88.97% -0.01%
==========================================
Files 651 651
Lines 81815 81812 -3
==========================================
- Hits 72793 72790 -3
Misses 9022 9022 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ESS_THAN
With USEGPU only SECONDARY_STRUCTURE_DRMSD ran on the GPU: the distances of STRANDS_CUTOFF and the switching functions (LESS_THAN, also with the mask) ran on the CPU, although the openaccPTM plugin provides DISTANCE_VECTORACC and LESS_THAN_VECTORACC. The shortcuts now pass USEGPU to them too. CUSTOM, LOWEST and SUM have no GPU version and stay on the CPU. Without USEGPU the expanded input is unchanged.
Tested with the plugin built with g++ and the host stub of the OpenACC runtime: the 47 targetGPU regtests pass (rt-GPU-secondarystructure and rt-GPU-secondarystructure-DRMSD now use DISTANCE_VECTORACC and LESS_THAN_VECTORACC); regtest/secondarystructure passes.
Claude-Session: https://claude.ai/code/session_016vwxtV46v5FLckcMEcJrbt
Description
Target release
I would like my code to appear in release XXXXX
Type of contribution
Copyright
COPYRIGHTfile with the correct license information. Code should be released under an open source license. I also used the commandcd src && ./header.sh mymodulenamein order to make sure the headers of the module are correct.Tests