chore(fleet): set Kubernetes 1.34 creation defaults only - #1037
Open
plural-copilot[bot] wants to merge 1 commit into
Open
chore(fleet): set Kubernetes 1.34 creation defaults only#1037plural-copilot[bot] wants to merge 1 commit into
plural-copilot[bot] wants to merge 1 commit into
Conversation
Author
There was a problem hiding this comment.
This PR was generated by the codex Plural Agent Runtime. Here's some useful information you might want to know to evaluate the ai's perfomance:
| Name | Details |
|---|---|
| 💬 Prompt | Create one reviewable PR to normalize Fleet cluster creation/setup defaults to Kubernetes 1.34.... |
| 🔗 Run history | View run history |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.34; it does not upgrade existing fleets or alter instantiated state underbootstrap/fleets/.template/fleet/dev.yamlandtemplate/fleet/prod.yamlso bothkubernetesVersionandnextKubernetesVersiondefault to1.34.kubernetes_versionandnext_kubernetes_versionnow default to1.34;release_channel = "UNSPECIFIED"and provider/module constraints are unchanged.1.34.kubernetes_vsntokubernetes_versionand updating its single internal reference. Shared templates already forwardkubernetes_version, so no template wiring or compatibility alias was required.template/clusters.yamlcreation defaults from1.28to1.34without changing its structure.Changed paths
template/fleet/dev.yamltemplate/fleet/prod.yamltemplate/clusters.yamlterraform/gke-cluster/variables.tfterraform/eks-cluster/variables.tfterraform/lke-cluster/variables.tfterraform/lke-cluster/lke.tfterraform/modules/gke/variables.tfValidation
Passed:
Caveats:
terraform fmt -check terraform/gke-cluster terraform/eks-cluster terraform/lke-cluster terraform/modules/gkereports pre-existing formatting differences throughout those directories. Formatting only the touched files also rewrote unrelated baseline formatting, so that output was reverted to keep this PR default-only and reviewable; changed Terraform lines retain the existing repository formatting.terraform validateforterraform/eks-clusteris blocked by existing compatibility issues when dependency resolution selects AWS provider6.62.0(legacy module arguments/blocks unsupported).terraform/modules/gkecannot complete init because its existing merged Google provider constraints are mutually incompatible. No provider/module constraints were changed.