Drop runtime pkg_resources dependency for setuptools >= 82 compatibility#4
Merged
Merged
Conversation
setuptools 82 removed the pkg_resources module entirely, which broke 'pacemaker' and pyace.multispecies_basisextension at import time (ModuleNotFoundError: No module named 'pkg_resources'). Replace pkg_resources.resource_filename with importlib.resources.files, keeping a pkg_resources fallback for Python 3.8 where importlib.resources.files is unavailable. Also drop the unused distutils.version.LooseVersion import from setup.py (distutils was removed from the stdlib in Python 3.12). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013rATYdnCXiGYC3bkbirURw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description of Changes
setuptools 82 removed the
pkg_resourcesmodule entirely (it was deprecated in 81), which broke this package at runtime:bin/pacemakerandsrc/pyace/multispecies_basisextension.pyfailed at import time withModuleNotFoundError: No module named 'pkg_resources'when installed alongside setuptools > 81.pkg_resources.resource_filename(...)withimportlib.resources.files(...)inbin/pacemakerandsrc/pyace/multispecies_basisextension.py, with apkg_resourcesfallback for Python 3.8 (the oldest supported version, whereimportlib.resources.filesis unavailable). This removes the implicit runtime dependency on setuptools altogether.from distutils.version import LooseVersionimport insetup.py(distutilswas removed from the stdlib in Python 3.12).Verified in a clean venv with setuptools 83.0.0 (no
pkg_resourcesmodule present): theimportlib.resourceslookup resolvespyace.dataresource paths correctly, andsetup.py egg_infostill succeeds.Checklist
License Agreement
By submitting this pull request, I agree that:
🤖 Generated with Claude Code
https://claude.ai/code/session_013rATYdnCXiGYC3bkbirURw
Generated by Claude Code