Repository navigation
Adds 'spo page unpublish' command. Closes #7540 - #7541
Conversation
|
@Anikesh348, please follow our guidelines and first ask to be assigned to an issue before working on it. This makes sure that there are not multiple people working on the same issue. |
There was a problem hiding this comment.
Pull request overview
Adds spo page unpublish for unpublishing modern SharePoint pages, including nested and extensionless page names.
Changes:
- Implements and registers the command.
- Adds comprehensive command tests.
- Adds command documentation and sidebar navigation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/m365/spo/commands/page/page-unpublish.ts |
Implements page unpublishing. |
src/m365/spo/commands/page/page-unpublish.spec.ts |
Tests behavior, validation, and errors. |
src/m365/spo/commands.ts |
Registers the command. |
docs/src/config/sidebars.ts |
Adds sidebar navigation. |
docs/docs/cmd/spo/page/page-unpublish.mdx |
Documents usage and examples. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Can you make the suggested changes by copilot and get you assigned to the issue? After this you can reopen the PR. |
acdcba6 to
24f52a1
Compare
|
Thanks for the review. I applied Copilot's two suggestions: the UnPublish request now uses Could you please assign me to #7540? I'm marking this PR ready for review. |
| }); | ||
|
|
||
| it('fails validation if webUrl is not a valid SharePoint URL', async () => { | ||
| const actual = commandOptionsSchema.safeParse({ webUrl: 'foo' }); |
milanholemans
left a comment
milanholemans
left a comment
There was a problem hiding this comment.
Apart from one comment, nothing to add, nice job!
| PAGE_PUBLISH: `${prefix} page publish`, | ||
| PAGE_REMOVE: `${prefix} page remove`, | ||
| PAGE_SET: `${prefix} page set`, | ||
| PAGE_UNPUBLISH: `${prefix} page unpublish`, |
There was a problem hiding this comment.
This file should be sorted strictly alphabetically.
24f52a1 to
eb71f60
Compare
|
Welcome to the team! |
Closes #7540
Summary
spo page unpublishfor modern SharePoint pages.aspxextensionsVerification
Executed in an isolated Node.js 24 container on
ubuntu-purva:npm ci --no-audit --no-fundnpm run buildnpm test(16,063 passing; 100% reported coverage)cd docs && npm ci --no-audit --no-fundnode scripts/create-docs-versioning.mjscd docs && npm run buildgit diff --checkLimitations
Local validation covered Linux with Node.js 24. Cross-platform and additional Node.js version coverage is left to the repository CI matrix.