chore(npm): approve install scripts for transitive dependencies - #19
Merged
Conversation
Record reviewed install scripts in allowScripts so npm install no longer warns about unreviewed postinstall hooks.
Regenerate the lockfile with npm 10 so esbuild@0.27.7 optional peer entries are present and npm ci --omit=peer succeeds on Node 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
allowScriptsfield topackage.jsonfor transitive dependencies that run install/postinstall scripts.package-lock.jsonwith npm 10 so CI can runnpm ci --omit=peeron Node 22.Why?
npm installon npm 11 printsallow-scriptswarnings for unreviewed install scripts (@parcel/watcher,core-js,core-js-pure,esbuild,fsevents,unrs-resolver). npm will eventually block unreviewed scripts; recording approvals now keeps installs clean and future-proof.esbuild@0.27.7that npm 10 (Node 22 on CI) requires.How?
npm approve-scripts --allto pin each package to its currently installed version.package-lock.jsonwith npm 10 so bothesbuild@0.28.1(direct) andesbuild@0.27.7(optional peer) are present.Test plan
npm installcompletes withoutallow-scriptswarningsnpm ci --omit=peersucceeds with npm 10npm run buildsucceeds