Repository navigation
retry: add cancelable retriers that cut their waits short on shutdown - #1
Merged
Merged
Conversation
The retrier used one context for three jobs: the deadline for the operation, the abort signal for the wait between attempts, and the loop's stop condition. Callers that need the operation to run to completion had to pass a context that is never cancelled, which also made every wait uninterruptible. Shutting down then meant sitting out the remaining backoff interval, once per in-flight operation. NewCancelableConstantRetrier and NewCancelableExponentialRetrier take a second context that governs the waits only. It never reaches the operation, so an attempt that has begun always finishes, and the operation still runs at least once. On stop, Retry returns the last attempt's value plus an error wrapping stop.Err(), letting a caller tell a shutdown from a genuine failure. The existing constructors leave the stop context nil and are unchanged: same uninterruptible initial sleep, same WithContextTimeout semantics. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retrier used one context for three jobs: the deadline for the operation,
the abort signal for the wait between attempts, and the loop's stop condition.
Callers that need the operation to run to completion had to pass a context that
is never cancelled, which also made every wait uninterruptible. Shutting down
then meant sitting out the remaining backoff interval, once per in-flight
operation.
NewCancelableConstantRetrier and NewCancelableExponentialRetrier take a second
context that governs the waits only. It never reaches the operation, so an
attempt that has begun always finishes, and the operation still runs at least
once. On stop, Retry returns the last attempt's value plus an error wrapping
stop.Err(), letting a caller tell a shutdown from a genuine failure.
The existing constructors leave the stop context nil and are unchanged: same
uninterruptible initial sleep, same WithContextTimeout semantics.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com