Skip to content

Added configurable timeouts for built-in plugins - #13

Merged
jamius19 merged 1 commit into
mainfrom
feature/add-configurable-timeout
Aug 9, 2026
Merged

jamius19 merged 1 commit into
mainfrom
feature/add-configurable-timeout

Conversation

@jamius19

@jamius19 jamius19 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added configurable timeouts for search, fetch, and ask operations.
    • Added default timeout settings of 10 seconds for search and fetch, and 30 seconds for ask.
    • Invalid or out-of-range timeout values are rejected.
  • Documentation

    • Documented timeout units, defaults, valid ranges, validation behavior, and operation-specific usage.
  • Tests

    • Added coverage for default, custom, and invalid timeout configurations.

@jamius19 jamius19 self-assigned this Aug 9, 2026
@jamius19 jamius19 added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 59326104-8468-443a-93e4-1a54a2f1c759

📥 Commits

Reviewing files that changed from the base of the PR and between 4cd0ba8 and 684e84c.

📒 Files selected for processing (27)
  • docs/CONFIGURATION.md
  • src/plugins/builtin-ai-ask/main.test.ts
  • src/plugins/builtin-ai-ask/main.ts
  • src/plugins/builtin-alterlab-fetch/main.test.ts
  • src/plugins/builtin-alterlab-fetch/main.ts
  • src/plugins/builtin-alterlab-search/main.test.ts
  • src/plugins/builtin-alterlab-search/main.ts
  • src/plugins/builtin-brightdata-fetch/main.test.ts
  • src/plugins/builtin-brightdata-fetch/main.ts
  • src/plugins/builtin-brightdata-search/main.test.ts
  • src/plugins/builtin-brightdata-search/main.ts
  • src/plugins/builtin-crawl4ai-fetch/main.test.ts
  • src/plugins/builtin-crawl4ai-fetch/main.ts
  • src/plugins/builtin-exa-fetch/main.test.ts
  • src/plugins/builtin-exa-fetch/main.ts
  • src/plugins/builtin-exa-search/main.test.ts
  • src/plugins/builtin-exa-search/main.ts
  • src/plugins/builtin-firecrawl-fetch/main.test.ts
  • src/plugins/builtin-firecrawl-fetch/main.ts
  • src/plugins/builtin-firecrawl-search/main.test.ts
  • src/plugins/builtin-firecrawl-search/main.ts
  • src/plugins/builtin-searxng-search/main.test.ts
  • src/plugins/builtin-searxng-search/main.ts
  • src/setup.test.ts
  • src/setup.ts
  • src/utils.test.ts
  • src/utils.ts

📝 Walkthrough

Walkthrough

The PR adds validated timeout configuration for search, fetch, and ask plugins. It adds defaults, documentation, shared parsing, plugin integration, and tests for default and custom timeout values.

Changes

Configurable plugin timeouts

Layer / File(s) Summary
Timeout parsing and validation
src/utils.ts, src/utils.test.ts
getPluginTimeout reads plugin-specific environment variables, applies defaults, and rejects invalid or out-of-range values.
Default configuration and documentation
src/setup.ts, src/setup.test.ts, docs/CONFIGURATION.md
Default search, fetch, and ask timeout variables are added. The documentation describes units, defaults, valid values, and timeout usage.
Plugin timeout integration
src/plugins/builtin-*/main.ts
Built-in search and fetch plugins use the configured search or fetch timeout. The ask plugin uses the configured ask timeout.
Timeout behavior coverage
src/plugins/builtin-*/main.test.ts
Tests verify default timeouts, environment overrides, abort-signal propagation, and isolated environment state.
Estimated code review effort: 3 (Moderate) ~20 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/add-configurable-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamius19
jamius19 merged commit 1995a88 into main Aug 9, 2026
1 of 2 checks passed
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant