Repository navigation
Fix placeholder cast truncated from parameter 1000 on - #221
Merged
davecramer merged 1 commit intoOct 12, 2026
Merged
Conversation
ResolveOneParam() writes each placeholder with its cast into a 16-byte buffer, so "$1000::timestamp" was cut to "$1000::timestam" and execution failed with: type "timestam" does not exist. Widen the buffer to 32 bytes and add a test with 1000 timestamp parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220.
ResolveOneParam()writes each placeholder, with its cast, into a 16-byte buffer (pnum[16]). From parameter number 1000 on,"$1000::timestamp"does not fit and is cut to"$1000::timestam", so the statement fails withtype "timestam" does not exist. This widens the buffer to 32 bytes.The new test,
many-params-test, binds 1000SQL_TYPE_TIMESTAMPparameters withUseServerSidePrepare=1and reads back column 1000. It fails with the error above without the fix and passes with it.Tested:
linux.ymlbuilds): the full suite passes with the fix; the new test fails without it.I used Claude Code for the initial scan of the problem and to write the test and the patch; it helps get the job done faster.