Skip to content

Fix vulnerable tar dependency in PRPM CLI - #280

Merged
khaliqgant merged 3 commits into
mainfrom
fix/upgrade-cli-tar
Oct 14, 2026
Merged

khaliqgant merged 3 commits into
mainfrom
fix/upgrade-cli-tar

Conversation

@khaliqgant

@khaliqgant khaliqgant commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Upgrade the CLI and registry to tar 7.5.22 to address the advisories shown during global CLI installation.
  • Upgrade registry bcrypt to 6.0.0, removing its transitive tar 6 dependency.
  • Align the CLI Node requirement, build target, and installation guide at Node 18+.
  • Verify that bcrypt 6 accepts a password hash generated with bcrypt 5.1.1.

Verification

  • npm ls tar --all resolves only tar 7.5.22.
  • Production npm audit reports no tar finding.
  • CLI typecheck and build pass; 56 focused archive/install/show tests pass.
  • Registry typecheck and build pass; package route tests pass (11 passed, 4 skipped); bcrypt compatibility test passes.
  • Veto diff review passes on all 6 changed files with no security or secrets findings.

The registry auth test file currently has 14 failing assertions against its route contract (for example, it expects a 201 registration response while the route returns 200, and sends identifier while the route requires email). Those files are unchanged in this PR.

@codeant-ai

codeant-ai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Reviewed your PR 02e0257 Oct 14, 2026 · 17:10 17:12

@codeant-ai

codeant-ai Bot commented Oct 14, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Oct 14, 2026
@codeant-ai

codeant-ai Bot commented Oct 14, 2026

Copy link
Copy Markdown

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; it aligns the CLI's documented and configured minimum Node.js version with the updated dependency requirements.
  • The bcrypt upgrade includes a test confirming that existing password hashes remain verifiable.

Assessed commit: 542da7d8e91b

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed against the latest diff

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread packages/cli/package.json

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

View guided diff | Re-trigger cubic

@khaliqgant

Copy link
Copy Markdown
Collaborator Author

CI note: The Registry Tests and E2E Registry Tests jobs fail in their Start MinIO step. Docker Hub returns pull access denied for minio/minio:latest, so neither job reaches typecheck or tests. The CLI, security, other package checks, and the CLI publish dry run pass. This image availability issue is separate from the dependency changes in this PR.

@khaliqgant
khaliqgant merged commit 6047ac5 into main Oct 14, 2026
9 of 11 checks passed
@khaliqgant
khaliqgant deleted the fix/upgrade-cli-tar branch October 14, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant