audio-knife: startup self-test for GOOGLE_APPLICATION_CREDENTIALS - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When
audio-knifeis deployed without a workingGOOGLE_APPLICATION_CREDENTIALSsetup, the misconfiguration only surfaces when thegoogle-transcribeservice fails at request time, which is hard to attribute during deployment. A startup check surfaces the problem immediately in the logs, without preventing startup of the parts that do work.Summary
audio-knife/src/selftest.rs: at startup, verifiesGOOGLE_APPLICATION_CREDENTIALSis set, readable, and valid JSON; logs a warning with context on the first problem found.main.rsbefore the server binds; failures never block startup.VERSIONING.mddocuments the rule that every behavioral change bumps at least the patch version, with a release history.Validation
cargo fmt -- --checkcleancargo test -p audio-knife: 5 passedcargo check -p audio-knifeclean at 3.8.1AI disclosure
This PR was prepared with GitHub Copilot (GLM-5.3-Flash). The change was implemented and reviewed with AI assistance; the final review found two accepted Low-severity notes (JSON-only validation, no dedicated tests).