keep-web: order after network-online.target when dialing the state relay#94
Conversation
Signed-off-by: Kyle 🐆 <kyle@privkey.io>
|
Warning Review limit reached
Next review available in: 23 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What
Order the
keep-webunit afternetwork-online.target(with a matchingwants) whenstateRelayis set, instead of only afternetwork.target.Why
With keep-state replication enabled,
keep-webdials out to the Nostr state relay at startup.network.targetonly means networking has been configured, not that it is routable — so on a real boot the daemon can start before the network is actually up and fail its initial dial.network-online.targetis the correct ordering for a service that makes outbound connections (and pulls in the wait-online service).The ordering is gated on
stateRelay != null, so a purely-localkeep-web(no outbound dial) is not delayed at boot.Until now this was masked only by
Restart=on-failure— a retry loop papering over a boot race, not a fix.Verification
Evaluated the unit for both cases:
stateRelayafterwantsnetwork.target,network-online.targetnetwork-online.targetnetwork.targetMatches intent exactly. The
keep-state-replicationVM test (which setsstateRelay) exercises this path.Closes keep-node-pw5.