Skip to content

Fix compatibility with thread-safe tape recording in ReverseDiff.jl #565

Closed

Description

@ztangent

JuliaDiff/ReverseDiff.jl#311 breaks our autodiff code because Gen uses ReverseDiff.jl's InstructionTape API internally to implement automatic differentiation. As far as I can tell, we will need to add a call to ReverseDiff.finish! before any call to ReverseDiff.reverse_pass!.

This should be a relatively straightforward fix (we don't call reverse_pass! in many places), but ideally we can do it in a way that's backwards compatible with earlier versions of ReverseDiff.jl.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions