fix(analytics): align Countme family sparkline domains with rendered images - #1192
Closed
Danathar wants to merge 2 commits into
Closed
fix(analytics): align Countme family sparkline domains with rendered images#1192Danathar wants to merge 2 commits into
Danathar wants to merge 2 commits into
Conversation
…images Derive workstation small multiples shared domain keys from BLUEFIN_FAMILY_IMAGES so the domain matches the family cards (Bluefin, Bluefin LTS, Dakota, Utah) instead of including external Aurora and omitting Dakota/Utah. Closes projectbluefin#1085 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Sep 10, 2026
Contributor
|
Superseded by #1201 rebased cleanly on latest main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CountmeAnalyticsCharts.tsxpreviously calculated the workstation shared sparkline domain from hardcoded keys["bluefin", "aurora", "bluefin-lts"], including external Aurora while omitting next-generation variants Dakota and Utah rendered in the family cards.Solution
BLUEFIN_FAMILY_IMAGES(BLUEFIN_FAMILY_IMAGES.map((img) => img.id)), ensuring the domain always stays aligned with the rendered family cards.ProjectBluefinImageSpecandBLUEFIN_FAMILY_IMAGES.scripts/countme-analytics-charts.test.jsvalidating that external variants (Aurora) are excluded from the family sparkline domain, next-gen variants (Dakota & Utah) are included, and all family cards share the same domain.Closes #1085
— hive: backend=agy
🐝 Hive Agent:
contributor| SHA:7f955f06