fix: use character as insert_text for character-valued ANSI_SEQUENCES entries - #2089
Open
dajiaohuang wants to merge 1 commit into
Open
fix: use character as insert_text for character-valued ANSI_SEQUENCES entries#2089dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
… entries When a character-valued entry is added to ANSI_SEQUENCES (e.g., for xterm modifyOtherKeys support), the KeyPress data should be the character, not the raw escape sequence. Otherwise, self-insert bindings will insert the escape sequence instead of the character. Fixes prompt-toolkit#2086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a character-valued entry is added to
ANSI_SEQUENCES(e.g., for xterm modifyOtherKeys support), theKeyPressdata should be the character, not the raw escape sequence. Otherwise, self-insert bindings will insert the escape sequence instead of the character.Fixes
Fixes #2086
Changes
src/prompt_toolkit/input/vt100_parser.py: In_call_handler, whenkeyis a plain character (not aKeysmember), use the character asinsert_textinstead of the raw escape sequencetests/test_inputstream.py: Add regression testtest_character_valued_ansi_sequenceBehavior Change
Before:
ANSI_SEQUENCES["\x1b[27;2;78~"] = "N"would causeKeyPress("N", "\x1b[27;2;78~")to be created, and self-insert would insert the raw escape sequenceAfter:
KeyPress("N", "N")is created, and self-insert correctly inserts "N"