This repository was archived by the owner on Sep 12, 2026. It is now read-only.
feat: Add PROTO.md grounding doc + CLAUDE.md/AGENTS.md pointers - #19
Merged
mabry1985 merged 1 commit intoAug 28, 2026
Merged
Conversation
Align pyproject.toml version to 0.6.4 to match protoagent.plugin.yaml (the version-coherence guard was red on this branch). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mabry1985
deleted the
feat/bd-qlhq-add-proto-md-grounding-doc-claude-md-age
branch
August 28, 2026 08:45
![protoreview[bot]](https://avatars.githubusercontent.com/in/4233969?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head afc493ffd70b · formal
No defects found across all four LLM review angles (correctness, removed-behavior, cross-file, conventions). Overall risk is low. Nothing to fix first. The panel was unanimous in finding no issues. The structural engine failed with a gateway auth error, so structural coverage (e.g., import-graph integrity, circular-dependency detection) was subsumed by the LLM passes only — a minor gap if the diff touches module boundaries in ways the LLM finders didn't explicitly probe.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PROTO.md, the canonical coder-grounding doc for this repo: what it is (standalone protoAgent pluginagent_browser, thin subprocess wrappers over the vercel-labsagent-browserCLI), the stack (Python 3.12, FastAPI routers, langchain-core tools, no build step), the gate command, the host-free test patterns, the key invariants, and a file-by-file layout.CLAUDE.mdandAGENTS.mdare thin pointers back to it.tests/test_docs.pyis added to guard the docs — it assertsPROTO.mdexists at the root and carries the gate command, test-pattern names, invariants, and file layout, and that both pointer files referencePROTO.md.One non-doc change was required to satisfy the "gate passes" criterion: the branch's version-coherence guard (
test_manifest_and_pyproject_versions_match) was already red because commit8085474bumpedprotoagent.plugin.yamlto0.6.4but leftpyproject.tomlat0.6.3. I alignedpyproject.tomlto0.6.4— a one-line fix that is exactly the "version must match in both files" invariant PROTO.md documents, and it turns the gate green.Note on the changelog convention: the repo does keep a
CHANGELOG.md, so rather than state "no changelog file" (which would be false in a grounding doc), PROTO.md documents the operative rule — changes are described in the PR title and commit message, withCHANGELOG.mdmaintained as version-keyed release notes at release time, not as a per-PR gate.