test: close plugin-store seam coverage gaps - #4
Merged
Conversation
![protoreview[bot]](https://avatars.githubusercontent.com/in/4233969?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head b8d3ca803802 · formal
All five finders returned zero findings and the structural verify pass confirmed an empty array — the panel unanimously found no defects in this diff. Overall risk is low; there is no fix-first item. The panel did not disagree on anything. Verification changed nothing (there was nothing to verify). No structural pass was skipped; the code-review-structural:verify workflow ran to completion on the empty findings list.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the late review on #3: adds plugin_store to the shared host stub, documents the seam, and fails closed with an explicit error when the host cannot supply an instance-scoped store instead of restoring the unsafe global-home fallback. Covers both a missing result and an SDK exception.
Validation: Ruff and formatting pass; pytest: 106 passed.
Follow-up to protoLabsAI/protoAgent#3083.