Skip to content

protoreview GitHub App isn't subscribed to pull_request_review_thread (pr-reviewer v0.37.0 wants it) #52

Description

@mabry1985

What

pr-reviewer-plugin v0.37.0 (shipped, now pinned as of #51) added: resolving a PR review thread triggers a check-run update via the pull_request_review_thread webhook event, clearing the QA panel check gate without waiting for a new push. Release notes call this out explicitly: "Action required: The GitHub App installation must subscribe to pull_request_review_thread for this webhook handler to receive events."

Current state

Checked via gh api /orgs/protoLabsAI/installations (2026-09-11): Vera's protoreview GitHub App (app_id 4233969) has checks: write already (so the QA panel check itself posts fine), but its subscribed events list is ["issues","issue_comment","pull_request","pull_request_review_comment"]pull_request_review_thread is not in it.

There's no REST API to update an existing GitHub App's webhook event subscriptions — it's a manual toggle at https://github.com/settings/apps/protoreview under Permissions & events.

Impact if left as-is

Not urgent / not broken: the QA panel check still posts and updates on every review round. The only gap is the specific convenience path — resolving a review thread alone won't clear a held check until the next push (or the next sweep-driven re-review) does it instead.

Ask

Someone with admin access to the protoreview GitHub App: add pull_request_review_thread to its subscribed webhook events.

Filed while doing the routine core 0.163.0 / pr-reviewer v0.38.0 update pass.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions