chore: pin pr-reviewer-plugin v0.36.0 — the QA panel check run - #49
Merged
Conversation
v0.36.0 publishes a `QA panel` check run from the same decision that drives approve-on-green (pr-reviewer-plugin#97). It is the first form of Vera's verdict that GitHub will gate a merge on: an App's approval never satisfies a required approving review (it counts reviewers with write access, and an App is not one), so until now a WARN with open findings — or a FAIL — could not stop a merge. Vera's live posture already owns promotion (`shadow_mode: false`, `promotion_owner: true`), and the check rides that same gate, so she starts publishing it for her repos on this roll. It stays inert until a repo's ruleset lists `QA panel` as a required status check. Needs the protoreview App granted `Checks: read & write`; without it the write logs a warning naming that permission and nothing else changes. Bundle manifest, Dockerfile bake ARG and the README member table move together — CI asserts all three agree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
QA panel review — PASS
code-review-structural · head f25943bf8efe · formal
PR #49 is a clean three-file version-pin bump (v0.35.0 → v0.36.0) for pr-reviewer-plugin: Dockerfile ARG, README table, and bundle manifest are all internally consistent. The verifier confirmed no defects. No prior requests to disposition. No panel disagreement. No coverage gaps — the change is small and fully walked.
No findings — the review came back clean.
findings JSON (machine-readable)
[]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up pr-reviewer-plugin#97: the panel publishes a
QA panelcheck run from the same decision that drives approve-on-green.Why it matters for Vera specifically: an App's approval never satisfies a required approving review (GitHub counts reviewers with write access; an App is not one), so her verdict could not stop a merge no matter how it was posted — a WARN with open findings and a clean PASS were equally unenforceable. A check run is a first-class required status.
Her live posture already owns promotion (
shadow_mode: false,promotion_owner: true) and the check rides that same gate, so she starts publishing on this roll. It stays inert until a repo's ruleset listsQA panelas a required check.Prerequisite: the protoreview App needs
Checks: read & write. Without it the write logs a warning naming that permission and nothing else changes.Manifest pin, Dockerfile bake ARG and the README member table move together — CI asserts all three agree.
🤖 Generated with Claude Code