Skip to content

Triage ESPHome-Config's Hand-Modified GOVERNANCE.md Workflow YAML Conventions Section #1572

Description

@ptr727

The regeneration in #1569 surfaced a verbatim section hand-modified downstream, with no entry in spec/divergences.json covering it, so it renders under reports/divergences.md "Untriaged".

  • GOVERNANCE.md > Workflow YAML Conventions - hand-modified in ESPHome-Config (verbatim canonical)

Untriaged here means something narrower than drift. The same section is stale in eight other repositories, and those render under "Mechanical re-vendor" instead, where the fix is to copy the current canonical down and no judgment is owed. ESPHome-Config's copy is neither the canonical nor a past hub revision, so a re-vendor would silently discard whatever was written into it, which is the case the ledger exists to make someone look at first.

Settling this takes reading ESPHome-Config's copy against the hub's canonical and deciding which the difference is:

  • re-vendor, if the edit is an accident or a stale local patch, the disposition eight of its siblings already carry by being stale.
  • upstream-candidate, if the downstream text is an improvement, in which case the hub adopts it and the copy is re-vendored afterward.
  • accepted, if the section legitimately varies for an operational repository, which would also mean the unit's verbatim fidelity in spec/files.json is the wrong label for it and intent is the right one.

A verbatim unit's whole point is that a stale-but-present copy is invisible under intent and caught here, so leaving this untriaged costs the section the drift detection it was classified for.

Closing this takes a ledger edit plus a regeneration, per the report's own generated-file header, never a hand-edit of the report.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions