Repository navigation
chore: bump locks-server to 0.1.1-rc1 - #104
Merged
Merged
Conversation
Inject the generated-config database URL in tests instead of racing on a process-global environment variable. Prioritize shutdown over ready republisher ticks and stress the simultaneous-ready regression.
5 of 10 tasks
Jasonvdb
reviewed
Oct 28, 2026
Jasonvdb
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locks-serverfrom workspace version0.1.0to0.1.1-rc1; update its matchingCargo.lockpackage entry.PUBKY_LOCK_DATABASE_URLmutation from config-loading tests while preserving production environment lookup.Cargo.lock; no source, manifest, workflow, or audit-policy changes.RustSec remediation
RUSTSEC-2026-0382:rustls-webpki0.103.15->0.103.16(fixed resolution).RUSTSEC-2026-0383:webpki-root-certs1.0.9->1.0.10(fixed resolution).RUSTSEC-2026-0381:webpki-roots1.0.9->1.0.10(fixed resolution).cargo audit --file Cargo.lock: passed with 0 vulnerabilities (advisory DB: 1348 advisories).RUSTSEC-2023-0089(atomic-polyfill, unmaintained),RUSTSEC-2026-0253(lru, unsound), and yankedchacha20 0.10.1.Root causes fixed
tokio::select!could choose ready interval tick after shutdown became ready, causing extra publish attempt.RED evidence
cargo test -p locks-server --locked --lib -- --test-threads=64: failed on first stress run, 364 passed / 1 failed; generated config database equality mismatch.3vs expected2.1087ee57b544dcf28a589d7853877663a3506858: failed onRUSTSEC-2026-0382,RUSTSEC-2026-0383, andRUSTSEC-2026-0381.GREEN evidence
cargo metadata --locked --format-version 1 >/dev/null: passed.cargo fmt --all -- --check: passed.cargo check --workspace --all-targets --all-features --locked: passed.cargo test -p locks-server --locked: passed; 365 library + 1 binary + 3 startup lifecycle + 0 doc tests, 0 failures.git diff --check ac8e893b4cb9d21b7736a431b511acd3efdfb83a..8f99a4313df00ec525aa1d6de878598caa195f24: passed.Review
Independently approved exact commit
8f99a4313df00ec525aa1d6de878598caa195f24(tree694c7e6aa524e0f5df97ba7c543580e2321e05fa) as a clean fast-forward from prior PR head1087ee57b544dcf28a589d7853877663a3506858, againstmasteratac8e893b4cb9d21b7736a431b511acd3efdfb83a.Residual risk
Checkssucceeded, while approved head received full workspace all-target/all-feature checking pluslocks-servertests locally.