Repository navigation
Report ESPHome transport failures as connection errors - #142
Draft
balloobbot wants to merge 2 commits into
Draft
balloobbot wants to merge 2 commits into
balloobbot wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #142 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 25 25
Lines 4391 4395 +4
=======================================
+ Hits 4141 4145 +4
Misses 250 250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Upstream issue to use ConnectionNotEstablishedAPIError for disconnected clients: esphome/aioesphomeapi#1948 |
balloobbot
marked this pull request as draft
October 17, 2026 12:01
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: we'd prefer to fix the exception type upstream first: esphome/aioesphomeapi#1948.
Map ESPHome transport failures to
ConnectionErrorso callers can retry after a proxy reboot. Preserve authentication/protocol errors asSerialException.Original report: home-assistant/core#186950.
Validation: 71 tests passed; 19 skipped without the ESPHome host binary. Repository checks passed.