Repository navigation
Add serialx.is_non_unique_serial - #143
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #143 +/- ##
=======================================
Coverage 94.30% 94.31%
=======================================
Files 25 25
Lines 4391 4397 +6
=======================================
+ Hits 4141 4147 +6
Misses 250 250 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Missing Windows-suffixed FTDI aliases cause known shared serial numbers to be classified as unique.
1 open issue
What changed in this PR
Adds SerialPortInfo.is_unique so downstream code can recognize known shared serial numbers without maintaining its own list.
Changes:
- Classifies missing, blank, and known shared serial numbers as non-unique.
- Keeps ESPHome device URLs tied to a port when serial numbers are non-unique.
- Adds classification and ESPHome clone coverage.
| File | Description |
|---|---|
| tests/test_serial_esphome.py | Adds a shared-serial device listing case. |
| tests/test_common.py | Tests serial-number uniqueness classification. |
| serialx/platforms/serial_esphome.py | Uses uniqueness to determine port binding. |
| serialx/common.py | Adds known shared serials and is_unique. |
Review effort: Balanced
is_unique to SerialPortInfoserialx.is_non_unique_serial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds
serialx.is_non_unique_serial. This allows downstream code to better deal with non-unique serial numbers (i.e. clones or early device variants) without building its own small database of bad serial numbers.