MAS implementation - #22
Merged
Merged
Conversation
Akaseli
marked this pull request as draft
June 11, 2026 12:04
Akaseli
force-pushed
the
mas-implementation
branch
from
July 8, 2026 06:49
fb772fd to
5560cdb
Compare
Akaseli
marked this pull request as ready for review
July 14, 2026 05:42
Akaseli
force-pushed
the
mas-implementation
branch
from
July 14, 2026 06:44
df43f1a to
28111a8
Compare
niilovuo
reviewed
Jul 14, 2026
| @@ -0,0 +1,154 @@ | |||
| """MAS (Matrix Authentication Service) admin API helper""" | |||
Contributor
There was a problem hiding this comment.
Should we just move this stuff under utils instead of synapseutils? Or maybe helpers or something
| return mas | ||
|
|
||
|
|
||
| async def synapse_startup(app: FastAPI) -> None: |
Contributor
There was a problem hiding this comment.
Should be renamed from synapse_startup to include mas
Contributor
Author
There was a problem hiding this comment.
renamed to connect_to_matrix
| async def test_ensure_user_existing_skips_create() -> None: | ||
| """Existing user: ULID returned from lookup, no create POST.""" | ||
| mas = _make_mas() | ||
| client = mas._client # pylint: disable=protected-access |
Contributor
There was a problem hiding this comment.
Nit for all pylint comments, I believe we are no longer using this tool here. Should be ruff comments instead (if needed at all)
Contributor
Author
There was a problem hiding this comment.
Removed all added (and existing) pylint comments.
niilovuo
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Summary
Why It's Good for the Product (Release Goal)