Conversation
N-0-MAD
force-pushed
the
fix-useless-unbatched-blockwise
branch
from
September 15, 2026 20:43
740d702 to
87b9f4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue in
local_useless_unbatched_blockwisewhere removing dummy batch dimensions could leave behind redundantSqueeze(ExpandDims(x))expressions.The rewrite now applies
apply_local_dimshuffle_liftafter squeezing the dummy dimensions, allowing these redundant dimension operations to be simplified before subsequent rewrites.This prevents equivalent computations from being treated as distinct and allows common factorizations to be merged. A regression test was added demonstrating that equivalent Cholesky factorizations result in a single
Choleskynode.Related Issue
Checklist
Type of change