gh-153578: Fix out-of-bounds write in bytearray.extend() with a reentrant __buffer__#153579
Open
tonghuaroot wants to merge 1 commit into
Open
gh-153578: Fix out-of-bounds write in bytearray.extend() with a reentrant __buffer__#153579tonghuaroot wants to merge 1 commit into
tonghuaroot wants to merge 1 commit into
Conversation
… reentrant __buffer__ bytearray.extend() clamped only the high bound of the append range to the current size after acquiring the argument's buffer, so a __buffer__ that shrinks the bytearray left the low bound past the high bound and ran a negative-size memmove. Clamp the low bound too, matching bytearray.__iadd__.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bytearray.extend()clamped only the high bound of the append range to the current size after acquiring theargument's buffer, so a
__buffer__that shrinks the bytearray left the low bound past the high bound and rana negative-size
memmove. Clamp the low bound too, matchingbytearray.__iadd__.