Infer yield-from item type for concrete Iterable subclasses#21724
Open
apoorva-01 wants to merge 1 commit into
Open
Infer yield-from item type for concrete Iterable subclasses#21724apoorva-01 wants to merge 1 commit into
apoorva-01 wants to merge 1 commit into
Conversation
get_generator_yield_type fell back to Any for a yield from over a user-defined Iterator subclass, hiding type mismatches; map it to Iterable like a for loop. Fixes python#17449.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17449
yield from over an Iterator/Iterable subclass was inferring Any, so this slipped by:
get_generator_yield_type only handles the generator types themselves, and a concrete subclass isn't one, so it bailed to Any. Now it maps to Iterable and takes the item type, like a for loop.
Also dodges the args[0] trap #20983 hit (enumerate came out
strinstead oftuple[int, str]). tests cover both, both fail without the fix.