Add/coordinate class - #33
Open
vhoogendijk wants to merge 6 commits into
Open
vhoogendijk wants to merge 6 commits into
vhoogendijk wants to merge 6 commits into
Conversation
vhoogendijk
marked this pull request as draft
May 2, 2025 12:25
ardjuh
suggested changes
May 2, 2025
Co-authored-by: Ard Geuze <63558466+ardjuh@users.noreply.github.com>
vhoogendijk
marked this pull request as ready for review
May 3, 2025 15:36
ardjuh
approved these changes
May 6, 2025
Author
|
units were not being converted so fixed that. Also when setting the coordinates using theta and phi the small unwanted values (order of e-8) would change phi a lot if in 1 or 0 state, so I added rounding. This worked in testbench. |
Contributor
|
This are final classes that we are using. These classes help a lot to keep track of everything and also to perform gates and things alike. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added two classes that represent the coordinates and the state of the qubit. This makes it easier to work with in the future, for example gate operations can be added under the quantum state class. The coordinate class makes conversion between the systems easier