Repository navigation
Revert "feat(overview): follow the system appearance like the cheat sheet (#268)" - #269
Merged
Merged
Conversation
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Restores the Overview panel’s dark Aqua backdrop and removes its system-dependent tint. The change is confined to presentation, with no configuration, shortcut, or data-handling changes. Notes:
You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #268. The maintainer prefers the Overview as it was: dark glass, forced
darkAqua, no tint.Sources/DefiMacOS/OverviewPanel.swiftis byte-identical to its version before #268 (git diff 0f24f11e HEAD -- Sources/DefiMacOS/OverviewPanel.swiftis empty).Proof: identical file to the previously shipped and verified state, and
make verifypassed.Merge Danger
Door: two-way
Blast Radius: cosmetic
Restores the Overview backdrop shipped before #268.
Note
Revert system-appearance tracking in the
OverviewPanelglass viewRemoves the dynamic black-or-white translucent tint that made the macOS 26 glass view follow the system appearance. The glass view (and the legacy visual-effect view) now uses the dark Aqua appearance after creation. See OverviewPanel.swift. Risk: the overview panel no longer switches tint between light and dark mode on macOS 26; it is always dark Aqua.
Macroscope summarized 6a53506.