Skip to content

test(campaign): pin 8 commands per steady tick — R3-S8's ceiling read (main red after #529 + #558) - #563

Merged
omercelikdev merged 1 commit into
mainfrom
fix/tick-query-count-after-r3s8
Nov 11, 2026
Merged

omercelikdev merged 1 commit into
mainfrom
fix/tick-query-count-after-r3s8

Conversation

@omercelikdev

Copy link
Copy Markdown
Collaborator

Why main is red

main@02128c5's ci fails in gates → unit tests: TickQueryCountTests.One_hungry_campaign_costs_a_fixed_number_of_commands_per_tick gets Expected: 7, Actual: 8 on every steady tick.

Two PRs were each green alone. Together they disagree on one number:

The textual merge was clean, so nothing caught it before main. My pre-merge check only simulated textual conflicts.

Proof that the 8th command is that read

I added a temporary SQL log to the test's interceptor; it is not committed. One steady tick on 02128c5 then issues:

  1. the campaign row,
  2. SELECT … FROM "GoldpathCampaignCeilings" (R3-S8's ReadCeilingsAsync),
  3. the claimable items,
  4. the batch state update,
  5. the ReleasedThrough update,
  6. the retry scan,
  7. the stale-claim scan,
  8. the campaign row.

Without line 2, the count is the 7 that #558 measured.

The change

Checked locally

  • Goldpath.Campaign.Tests: 506/506.
  • ledger-check rc 0, docs-freshness rc 0.

🤖 Generated with Claude Code

…d included (main red after #529 + #558)

#558 pinned 7 commands per steady tick, measured on a main without R3-S8. #529 (R3-S8, #290) landed first
and reads the live ceilings in one query a tick, by design (campaign RFC R3.2), so main counts 8 and
TickQueryCountTests is red on 02128c5. The extra command is that read: SELECT ... FROM "GoldpathCampaignCeilings",
as the interceptor's SQL log shows for a steady tick. The pin and the two prose mentions say 8 now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tier:B ADR-0014 Tier B: API, templates, deps, migrations; auto-merges once verified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant