Repository navigation
test(campaign): pin 8 commands per steady tick — R3-S8's ceiling read (main red after #529 + #558) - #563
Merged
Conversation
…d included (main red after #529 + #558) #558 pinned 7 commands per steady tick, measured on a main without R3-S8. #529 (R3-S8, #290) landed first and reads the live ceilings in one query a tick, by design (campaign RFC R3.2), so main counts 8 and TickQueryCountTests is red on 02128c5. The extra command is that read: SELECT ... FROM "GoldpathCampaignCeilings", as the interceptor's SQL log shows for a steady tick. The pin and the two prose mentions say 8 now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omercelikdev
added a commit
that referenced
this pull request
Nov 11, 2026
…tes red; no conflicts) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mainis redmain@02128c5'scifails ingates→ unit tests:TickQueryCountTests.One_hungry_campaign_costs_a_fixed_number_of_commands_per_tickgetsExpected: 7, Actual: 8on every steady tick.Two PRs were each green alone. Together they disagree on one number:
mainwithout R3-S8.The textual merge was clean, so nothing caught it before
main. My pre-merge check only simulated textual conflicts.Proof that the 8th command is that read
I added a temporary SQL log to the test's interceptor; it is not committed. One steady tick on
02128c5then issues:SELECT … FROM "GoldpathCampaignCeilings"(R3-S8'sReadCeilingsAsync),ReleasedThroughupdate,Without line 2, the count is the 7 that #558 measured.
The change
TickQueryCountTests:CommandsPerSteadyTick = 8, with a comment saying when and why it moved.ops/campaign-benchmarks.mdand feat(campaign): a tick's releases go out as one batch through an internal seam member (#285, throughput Part 3/3) #558's CHANGELOG line: the same note. The 2026-11-10 measurement stays as it was recorded.Checked locally
Goldpath.Campaign.Tests: 506/506.ledger-checkrc 0,docs-freshnessrc 0.🤖 Generated with Claude Code