Skip to content

fix(templates): Aspire 13.6.5 in both templates and CorPay (GHSA-f7vh-h5g3-7jrh) - #573

Merged
omercelikdev merged 1 commit into
mainfrom
fix/aspire-13.6.5-ghsa-f7vh
Nov 11, 2026
Merged

omercelikdev merged 1 commit into
mainfrom
fix/aspire-13.6.5-ghsa-f7vh

Conversation

@omercelikdev

Copy link
Copy Markdown
Collaborator

Why

GHSA-f7vh-h5g3-7jrh (CVE-2026-120006, high, Aspire elevation of privilege) was published on 2026-11-10 at 23:24 UTC.

  • It affects Aspire.Hosting and Aspire.Hosting.AppHost below 13.6.5.
  • Both templates and CorPay pinned 13.4.6.
  • A generated app has TreatWarningsAsErrors, so NU1903 is a restore failure. Every golden-manifest shape with an AppHost now goes red at PR time, whatever the PR touches. On feat(bench): the Bulk and Jobs benches run on Oracle behind a provider switch (G7 Oracle 8/12 Part 1/2, #556) #560's head a321d48, GmCleanFeatures, GmEverything, GmGrownRest and GmWorkerInSolution failed with error NU1903: … 'Aspire.Hosting' 13.4.6 has a known high severity vulnerability. That made the required golden manifests (PR subset) check red.

Dependabot does not cover the templates' pins, and the open #572 does not touch Aspire.

The change

  • Pins. templates/goldpath-solution, templates/goldpath-worker and samples/corpay pin every Aspire package at 13.6.5: AppHost, PostgreSQL, SqlServer, RabbitMQ, Redis and Testing, plus the Aspire.AppHost.Sdk in each AppHost. All nine Aspire ids the repo uses have 13.6.5 on nuget.org, Aspire.Hosting.Oracle included.
  • No CLI change. The CLI reads the Aspire version from the app's own Directory.Packages.props (FeatureRecipes.cs, PackagePins.Read). So a feature it adds later, such as Redis, RabbitMQ or Oracle, follows the new pin.
  • Docs.
    • CHANGELOG.md ### Fixed: one entry.
    • Template RFC D5: a dated note that the pin moved.
    • Oracle RFC §CLI: Aspire.Hosting.Oracle 13.6.5.
  • Unchanged on purpose. Goldpath.Cli.Tests (FakeApp.cs, OutboxRecipeTests.cs) keep 13.4.6 as fixture input. The CLI only reads that string; it is never restored.

Proof (local, macOS; audit on)

Green with the change. I took the first half of scripts/validate-gm.sh up to and including its "build (before db init)" step: build the console, pack the repo into a local feed, install the template, generate, wire the feed, build. Then I ran it on the four shapes that failed:

Shape Build
GmCleanFeatures ✓ 0 errors
GmEverything ✓ 0 errors
GmGrownRest ✓ 0 errors
GmWorkerInSolution ✓ 0 errors

The generated Directory.Packages.props and AppHost carry 13.6.5.

Red without it. I took the generated GmCleanFeatures and put its Aspire pins back to 13.4.6. A clean build then fails with exactly CI's errors: 4× NU1903 on Aspire.Hosting and Aspire.Hosting.AppHost.

The rest of the repo:

  • CorPay solution build: 0 errors.
  • Goldpath.Cli.Tests: 531/531.
  • ledger-check, docs-freshness, api-review-gate, schema-honesty, skills-parity, template-pins, train-freshness samples/corpay and surface-freeze-gate: rc 0.
  • merge-tier.py selftest: green.

Not run locally: db init, the smoke suites and the Oracle shape. They need Docker, and this machine does not run the Lima VM for routine work. CI's gm jobs run them.

For the owner: one new warning

Aspire 13.6 emits ASPIRE010 in every AppHost build:

AppHost is configured with AspireUseCliBundle=false. Some Aspire features require the Aspire CLI bundle.

It is an MSBuild-target warning, so TreatWarningsAsErrors does not turn it into an error, and every build above passes. A generated app's build is no longer warning-free, though. I left it visible rather than choose for you. There are two options:

  • set <AspireUseCliBundle>true</AspireUseCliBundle>, which changes what the AppHost needs at run time,
  • or add <NoWarn>$(NoWarn);ASPIRE010</NoWarn> to the AppHost projects.

Either can follow in this PR or the next.

Unblocks

🤖 Generated with Claude Code

…-h5g3-7jrh)

GHSA-f7vh-h5g3-7jrh (CVE-2026-120006, high) was published 2026-11-10 against
Aspire.Hosting and Aspire.Hosting.AppHost below 13.6.5. Under
TreatWarningsAsErrors, NU1903 failed restore in every golden-manifest shape
with an AppHost, so the required gm PR subset went red on every PR.

Both templates and CorPay now pin every Aspire package and Aspire.AppHost.Sdk
at 13.6.5. The CLI reads the Aspire version from the app's own props, so the
CLI does not change. CHANGELOG and the template and Oracle RFCs note the move.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the tier:C ADR-0014 Tier C: decisions, releases, gates, policy, agent layer; the owner merges label Nov 11, 2026
@omercelikdev omercelikdev added the owner-approved ADR-0014: the owner approves merging this Tier C agent PR label Nov 11, 2026
@omercelikdev
omercelikdev merged commit c9d23ae into main Nov 11, 2026
25 of 26 checks passed
@omercelikdev
omercelikdev deleted the fix/aspire-13.6.5-ghsa-f7vh branch November 11, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owner-approved ADR-0014: the owner approves merging this Tier C agent PR tier:C ADR-0014 Tier C: decisions, releases, gates, policy, agent layer; the owner merges

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant