Repository navigation
fix(templates): Aspire 13.6.5 in both templates and CorPay (GHSA-f7vh-h5g3-7jrh) - #573
Merged
Merged
Conversation
…-h5g3-7jrh) GHSA-f7vh-h5g3-7jrh (CVE-2026-120006, high) was published 2026-11-10 against Aspire.Hosting and Aspire.Hosting.AppHost below 13.6.5. Under TreatWarningsAsErrors, NU1903 failed restore in every golden-manifest shape with an AppHost, so the required gm PR subset went red on every PR. Both templates and CorPay now pin every Aspire package and Aspire.AppHost.Sdk at 13.6.5. The CLI reads the Aspire version from the app's own props, so the CLI does not change. CHANGELOG and the template and Oracle RFCs note the move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GHSA-f7vh-h5g3-7jrh (CVE-2026-120006, high, Aspire elevation of privilege) was published on 2026-11-10 at 23:24 UTC.
Aspire.HostingandAspire.Hosting.AppHostbelow 13.6.5.TreatWarningsAsErrors, so NU1903 is a restore failure. Every golden-manifest shape with an AppHost now goes red at PR time, whatever the PR touches. On feat(bench): the Bulk and Jobs benches run on Oracle behind a provider switch (G7 Oracle 8/12 Part 1/2, #556) #560's heada321d48, GmCleanFeatures, GmEverything, GmGrownRest and GmWorkerInSolution failed witherror NU1903: … 'Aspire.Hosting' 13.4.6 has a known high severity vulnerability. That made the requiredgolden manifests (PR subset)check red.Dependabot does not cover the templates' pins, and the open #572 does not touch Aspire.
The change
templates/goldpath-solution,templates/goldpath-workerandsamples/corpaypin every Aspire package at 13.6.5: AppHost, PostgreSQL, SqlServer, RabbitMQ, Redis and Testing, plus theAspire.AppHost.Sdkin each AppHost. All nine Aspire ids the repo uses have 13.6.5 on nuget.org,Aspire.Hosting.Oracleincluded.Directory.Packages.props(FeatureRecipes.cs,PackagePins.Read). So a feature it adds later, such as Redis, RabbitMQ or Oracle, follows the new pin.CHANGELOG.md### Fixed: one entry.Aspire.Hosting.Oracle13.6.5.Goldpath.Cli.Tests(FakeApp.cs,OutboxRecipeTests.cs) keep 13.4.6 as fixture input. The CLI only reads that string; it is never restored.Proof (local, macOS; audit on)
Green with the change. I took the first half of
scripts/validate-gm.shup to and including its "build (before db init)" step: build the console, pack the repo into a local feed, install the template, generate, wire the feed, build. Then I ran it on the four shapes that failed:The generated
Directory.Packages.propsand AppHost carry 13.6.5.Red without it. I took the generated GmCleanFeatures and put its Aspire pins back to 13.4.6. A clean build then fails with exactly CI's errors: 4×
NU1903onAspire.HostingandAspire.Hosting.AppHost.The rest of the repo:
Goldpath.Cli.Tests: 531/531.ledger-check,docs-freshness,api-review-gate,schema-honesty,skills-parity,template-pins,train-freshness samples/corpayandsurface-freeze-gate: rc 0.merge-tier.py selftest: green.Not run locally:
db init, the smoke suites and the Oracle shape. They need Docker, and this machine does not run the Lima VM for routine work. CI's gm jobs run them.For the owner: one new warning
Aspire 13.6 emits
ASPIRE010in every AppHost build:It is an MSBuild-target warning, so
TreatWarningsAsErrorsdoes not turn it into an error, and every build above passes. A generated app's build is no longer warning-free, though. I left it visible rather than choose for you. There are two options:<AspireUseCliBundle>true</AspireUseCliBundle>, which changes what the AppHost needs at run time,<NoWarn>$(NoWarn);ASPIRE010</NoWarn>to the AppHost projects.Either can follow in this PR or the next.
Unblocks
🤖 Generated with Claude Code