Repository navigation
feat(bench): the Campaign benches and S-FLEET-02's enumeration leg run on Oracle behind the provider switch (G7 Oracle 8/12 Part 2/2, #557) - #578
Conversation
…n on Oracle behind the provider switch (G7 Oracle 8/12 Part 2/2, #557) - CampaignBenchTests and CampaignPacerEnumerationBenchTests are written once on SuiteStore (#556's shape): PostgreSQL as before, and CampaignBenchOracleTests / CampaignPacerEnumerationBenchOracleTests on a fresh schema of the Oracle collection's pinned container, each carrying Category=Bench and Category=Oracle so neither per-PR lane runs them. - Every BENCH-CAMPAIGN line an Oracle run prints ends in provider=oracle; the enumeration leg reads the item table's size from USER_SEGMENTS on Oracle. - On Oracle the facts assert correctness (every target enumerated, every outcome counted, the live throttle bites) and print their numbers; the pacer's precision band binds PostgreSQL only (oracle RFC §6). - scripts/bench-campaign.sh takes GOLDPATH_BENCH_PROVIDER=postgres|oracle: all and enum run on Oracle, broker/smoke/fleet02 are refused in words (no broker-on Oracle shape before G5, #415), and an Oracle run that printed no provider=oracle line exits 1. - bench.yml's provider=oracle dispatch runs the Campaign benches after Bulk and Jobs, one after another. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018AFdNdQkwGfRCunWBAcuRC
…n one machine (#557) ops/campaign-benchmarks.md gains the Oracle column from the run of a326f1c on the overnight sandbox (Debug, Oracle Free 23.26.3, PostgreSQL 17 the same night): 1M enumerated at 8,516 rows/s (engine loop) and 8,177 rows/s through the pacer against 18,636 and 17,868; the governor at 166.7/s on both; the live throttle at 50.0 against 50.8; the 100k sink at 12,627 against 10,997/s. CHANGELOG [Unreleased], ga-gate-status G7 and scenario-campaign S-FLEET-02 name the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018AFdNdQkwGfRCunWBAcuRC
|
CI note: the red
Generated by Claude Code |
Verifier verdict (run 2026-11-13)Head verified: Verdict: no blocking findings. 0 BLOCKER, 0 MAJOR, 0 MINOR, 2 NIT. All four Oracle facts ran green on a real Oracle at full size. The issue's red proof reproduces exactly, and a mixed-provider run is refused too. Steps 1–6
Deep review
Edge-case probes (mine, throwaway, nothing pushed)
NITs (optional)
Not run
Labels: Owner: safe to merge. Summary: no package change. Generated by Claude Code |
What and why
G7 Oracle 8/12, Part 2 of 2 of #411. oracle RFC §6 asks for an Oracle column on each bench page, "measured, not promised". Umbrella #287 names S-FLEET-02's enumeration leg on Oracle. #556 (merged as #560) did Bulk and Jobs; this PR does Campaign, reusing #556's provider-switch shape exactly. No package change.
CampaignBenchTestsandCampaignPacerEnumerationBenchTestsare written once onSuiteStore. They are PostgreSQL as before: a container of their own, and the enumeration bench stays in the non-parallel broker-bench collection.CampaignBenchOracleTestsandCampaignPacerEnumerationBenchOracleTestseach run on a fresh schema of the Oracle collection's pinned container (OracleFixture.Image).Category=BenchandCategory=Oracle, so neither per-PR lane runs it.BENCH-CAMPAIGNline an Oracle run prints ends inprovider=oracle(BenchProvider.Tag).USER_SEGMENTSon Oracle (the table, its LOB and index segments) and frompg_table_size/pg_indexes_sizeon PostgreSQL, as before.scripts/bench-campaign.shtakesGOLDPATH_BENCH_PROVIDER=postgres|oracle, defaultpostgres, whose behaviour and output are unchanged.allruns both twins andenumruns the enumeration leg alone.broker,smokeandfleet02are refused in words (exit 2), because there is no broker-on Oracle shape before G5 (G7 Oracle 12/12: Add the broker-on Oracle shape GmOracleCampaign once the post-G5 engine ships an Oracle outbox store #415, owner decision 2026-10-23).provider=oracleline exits 1.bench.yml'sprovider=oracledispatch runsbench-campaign.sh allafter Bulk and Jobs, one after another, and the step fails if any of the three did. The PR is Tier C (bench-campaign.shis a Tier C path inmerge-tiers.yml, andbench.ymlis a workflow).The numbers (
packages/Goldpath.Campaign/ops/campaign-benchmarks.md, "Oracle column")Profile: the overnight agent's cloud sandbox, Linux x64, 4 logical CPUs / 15 GB, Docker 29.9, co-located, Debug (as the script runs). Oracle Free
23.26.3-slim-faststart, PostgreSQL17-alpine. Codea326f1c. One local run each, PostgreSQL the same night on the same machine; no run id.Nothing is an order of magnitude apart. Oracle enumerates at about half PostgreSQL's rate on one machine. The page gives a line of reading per row, including why Oracle's 251 B/item (allocated extents) is a coarser figure than PostgreSQL's.
Reproduce
I ran every line above. My first red attempt used plain
SuiteStore.PostgreSql()and also exited 1, but from the build (CS9113), not from the provider check; that is why the plant is written as above. Its run printed the PostgreSQL lines and then the refusal.Pre-PR self-check
OracleFixture's pinned image;broker/smoke/fleet02refused in words.CampaignPacerEnumerationBenchTestsran on Oracle at Campaign snapshot is no longer bound to the leader tick, and the 35M enumeration is measured #288's size (1M). The 35M size is not run on Oracle: that is about an hour at the measured rate on this profile, and the page says so with the reason (time).bench.yml's Oracle dispatch covers the Campaign benches. Tier C.[Unreleased];ga-gate-status.mdG7 names the page;scenario-campaign.mdS-FLEET-02 notes the Oracle enumeration evidence (as the snapshot's rate, not the scenario's verdict).coverage-matrix.mdhas no Bench column, so it is unchanged.bench.ymlthe three scripts run one after another. The two local runs were taken one after the other with nothing else running.<summary>. No member was inserted between an existing comment and its declaration.bench-fleet02.ymland anything grepping them is unaffected.#556's idioms (SuiteStore,BenchProvider.Tag, the twin-class pattern). No suppression.Gates run (head
d49294b)dotnet build Goldpath.sln -c Releasescripts/docs-freshness.shscripts/ledger-check.shscripts/schema-honesty.shscripts/skills-parity.shscripts/template-pins.shall(4 facts) / PostgreSQL same factsWhat I could not verify
bench.ymlwithprovider=oracleon the CI profile: I cannot dispatch a workflow. The step's shell is exercised locally through the same scripts. The 90-minute job timeout is unchanged; the Campaign part took about 6 minutes here, on top of G7 Oracle 8/12 Part 1/2: Run the Bulk and Jobs benches on Oracle behind a provider switch, and add the Oracle column to their pages #556's Bulk and Jobs.Closes #557
#411 stays open: its Bulk column waits on #559 (open-threads T68).
Generated by Claude Code