fix: repair failing tests and type errors across the monorepo

apps/web/src/lib/api.ts

@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }

bunfig.toml

@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
+preload = ["./packages/ui/test/setup.ts"]

packages/ui/src/components/Button/Button.tsx

@@ -14,16 +14,33 @@ type Props = {
   "aria-label"?: string
 }
 
+/**
+ * Derives an accessible name from string-like children. Returns undefined when
+ * the children contain no usable text (elements, null, booleans, whitespace).
+ */
+function textFromChildren(children: React.ReactNode): string | undefined {
+  if (typeof children === "string" || typeof children === "number") {
+    const text = String(children).trim()
+    return text.length > 0 ? text : undefined
+  }
+  if (Array.isArray(children)) {
+    const text = children
+      .map((child) => textFromChildren(child as React.ReactNode))
+      .filter((part): part is string => part !== undefined)
+      .join(" ")
+      .trim()
+    return text.length > 0 ? text : undefined
+  }
+  return undefined
+}
+
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button renders no visible text, so it needs an explicit
+ * `aria-label` to expose an accessible name (WCAG 2.2 SC 4.1.2). When one is not
+ * supplied, fall back to any text content in `children` before resorting to the
+ * generic "button" label, which conveys nothing beyond the element's own role.
  */
 export function Button({
   children,
@@ -39,8 +56,7 @@ export function Button({
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={ariaLabel ?? (iconOnly ? (textFromChildren(children) ?? "button") : undefined)}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}

packages/ui/src/components/DataTable/DataTable.tsx

@@ -16,22 +16,19 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * The sort-direction toggle derives its next value from the previous one, so it
+ * uses the functional form of setState (`setSortDir((prev) => ...)`). This is the
+ * correct and robust pattern for previous-state-derived updates: the updater is
+ * always applied to the latest committed value rather than to whatever `sortDir`
+ * happened to be captured in the closure at render time.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")

packages/utils/src/format/date.ts

@@ -1,19 +1,20 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * `formatDate` produces Australian-style D/MM/YYYY (e.g. 1/03/2024, 15/06/2024).
  *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * The `en-GB` locale is used deliberately rather than `en-AU`: both order the
+ * fields day-first, but ICU resolves `day: 'numeric'` to `2-digit` under
+ * `en-AU`, which zero-pads single-digit days to `01`. `en-GB` honours
+ * `day: 'numeric'`, giving an unpadded day alongside a 2-digit month.
+ *
+ * Note: `dateStyle: 'short'` is not a substitute here — it yields a 2-digit
+ * year (`1/3/24`) and cannot be combined with explicit `day`/`month` options.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  return new Intl.DateTimeFormat("en-GB", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
   }).format(date)
 }

tsconfig.json

@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]