fix: repair cross-package bugs so all tests pass and typecheck is clean

apps/web/src/lib/api.ts

@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-local name
+export { useDebounce as useSearchDebounce }

bun.d.ts

@@ -0,0 +1 @@
+/// <reference types="bun-types" />

bunfig.toml

@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
+preload = ["./packages/ui/test/setup.ts"]

packages/ui/src/components/Button/Button.tsx

@@ -17,13 +17,12 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must expose an accessible
+ * name via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value).
+ * The `aria-label` prop is forwarded to the underlying <button>. When
+ * `iconOnly` is set without an `aria-label`, a string child is used as a
+ * fallback name and a development warning is emitted so the omission is
+ * caught before it reaches production.
  */
 export function Button({
   children,
@@ -34,16 +33,26 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const fallbackLabel = typeof children === "string" ? children : "button"
+  const accessibleName = iconOnly ? ariaLabel ?? fallbackLabel : ariaLabel
+
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") {
+    console.warn(
+      "[Button] An icon-only Button was rendered without an `aria-label`. " +
+        "Icon-only controls must have an accessible name (WCAG 2.2 SC 4.1.2). " +
+        `Falling back to "${fallbackLabel}".`,
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleName}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
     </button>
   )
-}
+}

packages/ui/src/components/DataTable/DataTable.tsx

@@ -16,22 +16,18 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Clicking a sortable column header sorts ascending; clicking the same header
+ * again toggles to descending. The direction toggle uses the functional form
+ * of setState so it always reads the current value rather than the value
+ * captured when the handler was created.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")

packages/utils/src/format/date.ts

@@ -1,19 +1,15 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Australian date convention is day-before-month (D/MM/YYYY) with no
+ * zero-padding on the day. Bun's bundled ICU data for `en-AU` zero-pads the
+ * day even when `day: 'numeric'` is requested, so `en-GB` — which shares the
+ * same day/month/year ordering — is used to get an unpadded day.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  return new Intl.DateTimeFormat("en-GB", {
     day: "numeric",
+    month: "2-digit",
     year: "numeric",
   }).format(date)
 }
@@ -23,4 +19,4 @@ export function formatDateTime(date: Date): string {
     dateStyle: "short",
     timeStyle: "short",
   }).format(date)
-}
+}

tsconfig.json

@@ -11,5 +11,10 @@
       "@e2e/utils": ["./packages/utils/src/index.ts"]
     }
   },
-  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*"]
+  "include": [
+    "bun.d.ts",
+    "packages/*/src/**/*",
+    "packages/*/test/**/*",
+    "apps/*/src/**/*"
+  ]
 }