fix: repair all failing tests in utility library - #317
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: fix wordCount for consecutive whitespace; implement truncate with word-boundary and ellipsis budget - task-manager: implement remove, update (partial fields), and sortBy (priority/status/createdAt) - date-utils: fix off-by-one in formatRelative by rounding absolute day diff - validator: isEmail accepts subdomains and long TLDs; isUrl accepts URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across 5 source files. Test suite now 60 pass / 0 fail (was 44/16),
bunx tsc --noEmitclean. No test files modified, no dependencies added.Changes
src/calculator.ts—dividethrowsError("Division by zero")when the divisor is0instead of returningInfinity.src/string-utils.ts—wordCountsplits on\s+after trim (fixes phantom words from consecutive spaces);truncateimplemented with word-boundary cut-back and ellipsis counted towardmaxLength.src/task-manager.ts— implementedremove(returnsMap.deleteboolean),update(applies only defined fields,falsefor unknown id), andsortBy(priority high→medium→low, status, createdAt oldest-first).src/date-utils.ts—formatRelativeday bucket usesMath.round(Math.abs(diffHours)/24), fixing the off-by-one (36h → "2 days ago") symmetrically for past and future.src/validator.ts—isEmailaccepts subdomains and TLDs of 2+ letters (user@example.museum);isUrlaccepts URLs with ports (http://localhost:3000).Verification
bun test→ 60 pass, 0 failbunx tsc --noEmit→ exit 0Assumptions & notes
updatecannot clear an optional field viaundefined(JSON-merge semantics);truncate's word-boundary heuristic can under-fill the budget when the first word is long.sortBystatus ordering (in_progress > pending > completed) is not test-specified.