fix: repair failing tests across calculator, string, date, task, and validation utils - #327
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests across calculator, string, date, task, and validation utils#327stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ion utils - calculator: divide throws on division by zero instead of returning Infinity - string-utils: wordCount collapses consecutive whitespace; implement truncate with word-boundary back-off and ellipsis counting toward maxLength - task-manager: implement remove/update/sortBy with partial-update safety - date-utils: formatRelative rounds day count (fixes off-by-one at 36h) - validator: isEmail accepts longer TLDs; isUrl accepts host:port URLs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests (now 60 pass / 0 fail) across five utility modules. No test files were modified and no dependencies were added — only the source functions the tests exercise were changed.
Changes
dividenow throwsError("Division by zero")when the divisor is0, instead of silently returningInfinity.wordCountsplits on/\s+/(collapses consecutive whitespace, returns 0 for whitespace-only);truncateimplemented with word-boundary back-off and ellipsis counting towardmaxLength, never exceeding it.remove(hit/miss),update(safe partial updates), andsortBy(priority/status rank maps, oldest-first oncreatedAt).formatRelativerounds the day count, fixing the off-by-one (36h → "2 days"); past/future branches symmetric.isEmailaccepts TLDs > 4 chars;isUrlacceptshost:portURLs while keeping the http/https allowlist.Verification
bun test→ 60 pass, 0 failtsc --noEmit→ cleantruncateword-boundary over-fit found in review were corrected before commit.Assumptions / notes
isEmailremains a permissive shape check, not RFC 5322 validation.test/left untouched per the brief; a couple of untested edge paths noted for follow-up, out of scope here.