Repository navigation
Bound the node IP copy to the mNodeIp buffer - #134
Merged
fnordspace merged 1 commit intoOct 20, 2026
Merged
Conversation
This was referenced Oct 7, 2026
fnordspace
requested changes
Oct 15, 2026
fnordspace
left a comment
fnordspace
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR. Looks good. However the change in proposal.cpp is not needed since the size is already check on earlier. Please drop this change from the PR and adjust the description.
The QubicConnection constructor memcpy'd strlen(nodeIp) bytes into the 32-byte mNodeIp without a bound, so a node address longer than 31 chars (e.g. a full IPv6 string) overran the buffer. Copy at most 31 bytes and keep the trailing null terminator.
parthod0x
force-pushed
the
fix/nodeip-and-url-buffer-overflows
branch
from
October 15, 2026 18:18
49c183a to
5f93351
Compare
Contributor
Author
|
Dropped the |
parthod0x
changed the title
fnordspace
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
QubicConnectionconstructor copiedstrlen(nodeIp)bytes into the 32-bytemNodeIpwith no bound, so a node address longer than 31 chars (e.g. a full IPv6 string) overran the buffer. Copy at most 31 bytes and keep the trailing null.Per review, the earlier
proposal.cppURL change was dropped (that size is already checked upstream). Rebased onto current main; the config-file seed/node_ip bounds landed separately in #133.