fix: prevent auth token refresh failure from deadlocking the client

[glasstiger]

Problem

When OIDC is used, Client.refreshAuthToken() proactively refreshes the token ~30s before expires_in elapses. The token fetch was performed inside an async setInterval callback:

const interval = setInterval(async () => {
  if (Client.numOfPendingQueries === 0) {
    clearInterval(interval)
    const newToken = await this.refreshTokenMethod()  // <-- rejects here
    ...
    Client.refreshTokenPending = false   // <-- never reached
    return resolve(true)                 // <-- never reached
  }
}, 50)

If refreshTokenMethod() rejected — a transport-level failure such as the token endpoint being unreachable, a CORS/DNS error, or a non-JSON response body (e.g. a reverse-proxy 502 HTML page) — the await threw before the flag was reset:

• The outer promise never settled, so await this.refreshAuthToken() hung forever (it never even rejected).
• The static refreshTokenPending flag was left stuck true.
• Every subsequent query then deadlocked on the while (Client.refreshTokenPending) wait loop.

Net effect: the Web Console silently froze — no query ran, no 401 was triggered, no logout, no error surfaced. Only a manual page reload recovered it.

This only affected the transport-failure case. A well-formed OAuth error response (e.g. invalid_grant for an expired refresh token) already degraded gracefully to the login screen, as does the no-refresh-token case (401 → logout).

Fix

Restructure refreshAuthToken() so the failure can't escape without cleanup:

• The setInterval now only waits for in-flight queries to drain, then resolve()s — a plain synchronous callback, no swallowed errors.
• The refreshTokenMethod() call moves into the main async body, wrapped in try/catch/finally.
• finally always resets refreshTokenPending — it can never get stuck again.
• catch logs and swallows the error, keeping the stale token in place. The next request then receives a 401, which drives the existing MSG_CONNECTION_UNAUTHORIZED → logout flow — consistent with the no-refresh-token path.

The concurrency invariant is preserved: while refreshTokenPending is true, no new query passes the gate to increment numOfPendingQueries, so "0 pending queries when we refresh" still holds.

Testing

• Added a regression test in client.test.ts: with an in-window SSO token and a refreshTokenMethod that rejects, the query still resolves, console.error fires, and a second query also goes through (proving the flag was reset). Against the old code this test hangs to timeout; against the fix it passes in ~100ms.
• yarn test:unit src/utils/questdb/client.test.ts — 3/3 pass
• tsc --noEmit — no new errors
• eslint on both changed files — clean

🤖 Generated with Claude Code