Repository navigation
Per-performer recording quality for live recordings - #32
Conversation
- New sources.recording_max_height column (0 = automatic, highest available), added automatically to existing databases. - PATCH /api/sources/:id accepts recordingMaxHeight (0-4320). - The downloader passes the source's value to the plugin as recordingMaxHeight for that download only; the plugin's own settings are not changed. Automatic (0) keeps the plugin setting. - Recording quality is included in backup export and import. - Tests: server/recording-quality.test.ts (storage, migration, override and an end-to-end download check) and updated server/backup.test.ts.
- Each profile URL with a live plugin (Stripchat, CAM4, BongaCams, Chaturbate, Twitch, CamSoda, etc.) gets a "Recording quality" selector in Manage profile. - Choices: Automatic (highest), or up to 2160p, 1440p, 1080p, 720p, 480p, 360p or 240p. The setting is saved per performer and per site. - The selector spans the full width of the source controls, so it also fits on small screens.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
- New shared plugins/hls-quality.ts parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height: the best at or below it first, then the closest larger one, so a missing quality never fails. - Stripchat, CAM4 and BongaCams pick their live variant with it; automatic keeps the current behaviour (highest first). - yt-dlp based live plugins (Chaturbate, Twitch and the live-cam factory used by CamSoda, MyFreeCams, LiveJasmin, XCams and Cams) pass the height to yt-dlp with a fallback and --format-sort res:N. - Tests for variant parsing and ordering, and for the selected variant in Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
… cancels and lost recordings - Stripchat favorites: when the direct API is refused (HTTP 403/418), read the followed list inside a real Stripchat page with the saved session (easyx-browser-fetch --stripchat-favorites). Local favorites are kept on failure. - Stop and save no longer blocks the room: a performer who stays online is recorded again as a new video. Cancel still blocks until offline; a hard refresh of the source now lifts it. - A cancel the recording process ignores is forced (SIGKILL) after 10 s; a stop that hangs gets a second SIGINT after 45 s. - Shutdown saves running live recordings first (EASYX_SHUTDOWN_GRACE_SECONDS, default 60; compose stop_grace_period 90s). Recordings cut off by a crash or a killed container are joined from their parts on the next start; unreadable data is kept in media/.recording-recovery. - Tests: server/live-restart.test.ts and Stripchat favorites fallback tests.
|
Thanks for the detailed report. I've prepared fixes for all four points in my fork (MajorLOL/OpenEasyX) and will open a pull request:
|
|
Thanks for the thorough work! I reviewed the full diff and merged it:
I ran the full suite on the branch before merging: 504 tests pass, TypeScript and the production build are clean. Thank you again for the detailed report and the well-structured commits! |
Summary
Adds a "Recording quality" setting per performer source (per performer and per plugin) in Manage profile. The default is Automatic (highest), which keeps the current behaviour.
What changed
UI (
src/)Server (
server/)sources.recording_max_heightcolumn (0 = automatic), added automatically to existing databases.PATCH /api/sources/:idacceptsrecordingMaxHeight(0–4320).recordingMaxHeightfor that download only; the plugin's own settings are not changed. Automatic keeps the plugin setting, so the existing Chaturbate "Maximum recording height" still applies.Plugins (
plugins/)plugins/hls-quality.ts: parses HLS variants (RESOLUTION, NAME or playlist name) and orders them for a maximum height. The best variant at or below it comes first, then the closest larger one, so a missing quality never fails a recording.--format-sort res:N.Testing
npm run check: 494 tests pass, TypeScript and build OK.plugins/hls-quality.test.ts,server/recording-quality.test.ts(storage, migration, config override and an end-to-end download through the queue), and quality cases for the Stripchat, CAM4, BongaCams, Chaturbate and yt-dlp recordings.