Repository navigation
docs: fix CONTRIBUTING biome link, release script, and v2 version note - #2706
imitater-dou wants to merge 1 commit into
Conversation
Signed-off-by: ADou <ikun3.1415927@gmail.com>
|
|
@imitater-dou is attempting to deploy a commit to the rainbowdotme Team on Vercel. A member of the Team first needs to authorize it. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3b9f55d5e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| **This section is only relevant for library maintainers who are releasing new versions of the library.** | ||
|
|
||
| When you’re ready to publish, the `chore: version packages` PR should be reviewed to double check that the version number(s) are correct and that the release notes are correct. Since we’re currently in beta, version numbers should remain within the `v0.x` range. | ||
| When you’re ready to publish, the `chore: version packages` PR should be reviewed to double check that the version number(s) are correct and that the release notes are correct. Version numbers should remain within the `v2.x` range, consistent with the changeset guidance above. |
There was a problem hiding this comment.
When a version PR includes another public package, this instruction incorrectly says its version must be in v2.x: at this commit @rainbow-me/rainbowkit-siwe-next-auth, @rainbow-me/create-rainbowkit, and @rainbow-me/rainbow-button are respectively 0.6.0, 0.3.17, and 0.2.28, and the immediately preceding version-packages commit bumps them within those ranges. Following this guidance would therefore require unwarranted major releases or rejection of valid release PRs; scope v2.x to @rainbow-me/rainbowkit and preserve each other package's own major.
AGENTS.md reference: AGENTS.md:L104-L107
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Small CONTRIBUTING.md accuracy fixes verified against tip
03360ee:[biome.json](../.biome.json)404s; the repo root file isbiome.json(no leading dot).prereleasescript;package.jsonwiresreleaseaspnpm release:verify-git && …, so the gate isrelease:verify-git.v0.x”, which conflicts with the changeset guidance to stay inv2.0and with@rainbow-me/rainbowkit@2.2.11.Repro
.biome.json;biome.jsonexists at repo root.package.jsonscripts: noprerelease;releaseinvokesrelease:verify-git.2.2.11(not v0.x / beta).Test plan
.github/CONTRIBUTING.mdpackage.jsonscripts