fix: a failed write no longer follows you to the next row - #1521
Merged
Merged
Conversation
The banner renders above the whole slot list, so a failure left over from one slot read as if it belonged to whatever row you moved on to. Cleared when editing starts, alongside the existing clears on cancel and on the next submit. Also drops the doc comment for _wasRevealedBeforeEdit, which #1519 removed the field but not the comment for. Entire-Checkpoint: a3fbd4f54295
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 66 66
Lines 8457 8458 +1
Branches 521 521
=======================================
+ Hits 8389 8390 +1
Misses 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Two leftovers from #1519, found by a review pass over it.
A failed write followed you to the next row.
_writeErrorrenders above the whole slot list, and_startEditingdid not clear it. Fail a write on slot 1, then click slot 2's row directly instead of cancelling: slot 1's error sits above the row you are now typing into, reading as though it belongs to it. Cleared on edit start now, alongside the existing clears on cancel and on the next submit.A doc comment outlived its field. #1519 removed
_wasRevealedBeforeEditbut left/** Whether codes were revealed before editing started */behind with nothing under it.Type of change
Additional information
expected 'Code already in use' to be undefined.prekclean; bundle rebuilt.