Skip to content

fix: a failed write no longer follows you to the next row - #1521

Merged
raman325 merged 1 commit into
mainfrom
fix/card-write-error-scope
Aug 29, 2026
Merged

raman325 merged 1 commit into
mainfrom
fix/card-write-error-scope

Conversation

@raman325

@raman325 raman325 commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Proposed change

Two leftovers from #1519, found by a review pass over it.

A failed write followed you to the next row. _writeError renders above the whole slot list, and _startEditing did not clear it. Fail a write on slot 1, then click slot 2's row directly instead of cancelling: slot 1's error sits above the row you are now typing into, reading as though it belongs to it. Cleared on edit start now, alongside the existing clears on cancel and on the next submit.

A doc comment outlived its field. #1519 removed _wasRevealedBeforeEdit but left /** Whether codes were revealed before editing started */ behind with nothing under it.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • The new test is mutation-verified: dropping the clear fails it with expected 'Code already in use' to be undefined.
  • Frontend suite green (820); prek clean; bundle rebuilt.

The banner renders above the whole slot list, so a failure left over
from one slot read as if it belonged to whatever row you moved on to.
Cleared when editing starts, alongside the existing clears on cancel and
on the next submit.

Also drops the doc comment for _wasRevealedBeforeEdit, which #1519
removed the field but not the comment for.

Entire-Checkpoint: a3fbd4f54295
Copilot AI lite review requested due to automatic review settings August 29, 2026 04:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added javascript Pull requests that update javascript code breaking-change Pull requests that break existing functionality bug Something isn't working labels Aug 29, 2026
@raman325
raman325 merged commit 3280b44 into main Aug 29, 2026
11 checks passed
@raman325
raman325 deleted the fix/card-write-error-scope branch August 29, 2026 04:15
@codecov

codecov Bot commented Aug 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.19%. Comparing base (6d14528) to head (53d3e8d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1521   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          66       66           
  Lines        8457     8458    +1     
  Branches      521      521           
=======================================
+ Hits         8389     8390    +1     
  Misses         68       68           
Flag Coverage Δ
typescript 95.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ts/lock-codes-card.ts 90.46% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raman325 raman325 removed the breaking-change Pull requests that break existing functionality label Aug 29, 2026
raman325 added a commit that referenced this pull request Aug 29, 2026
* origin/main:
  fix: releasing a slot no longer adopts a user LCM never created (#1522)
  fix: a failed write no longer follows you to the next row (#1521)

# Conflicts:
#	custom_components/lock_code_manager/www/generated/lock-code-manager.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants