feat: add findings summary command (per-resource rollup) - #27
Merged
Merged
Conversation
Groups findings.json by resource_id and shows finding count, triggering policies and combined estimated impact per resource, sorted by impact. --min-findings filters to resources hit by multiple checks. Closes raphgm#16
raphgm
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Adds
cloudcost findings summary, a rolled-up view offindings.jsongrouped byresource_id, for deciding which resource to fix first when one resource trips several checks (e.g. stopped-not-deallocated and untagged).For each resource it shows the number of findings, the policies that fired, and the combined estimated impact, sorted by impact (highest first), followed by a total.
--min-findings Nshows only resources with at least N findings (--min-findings 2= resources hit by multiple checks)--inputaccepts a findings file path, matchingfindings notifyresource_id(e.g. the GitHub Actions check) are skipped, since there is nothing to group them onfindings.jsonitself is unchanged; each finding stays independentTesting
tests/test_findings_summary.py: grouping and sort order, the--min-findingsfilter, and a missing input file