Repository navigation
test: exercise production paths and clarify suite results - #485
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copied launch logic, weak success checks, and ambiguous suite output made regressions easy to miss and failures difficult to diagnose. This change exercises production paths, requires successful exit codes and positive completion evidence, and reports an explicit overall suite verdict.
.test_output/, rotate to at most three runs, and provide a host/container-compatiblelatestlink.Linked issue
None.
Checklist
bash test/run-tests.shandbash test/run-integration-tests.sh. The main suite passed on macOS with Docker; the live-provider integration suite has not been rerun.--checkscripts (test/regen-config-docs.sh --check,test/regen-template.sh --check) — no drift.SPECIFICATION.md,CLAUDE.md, configuration guidance, and the testing plan for the behavior changes.sandyis still a single file with no new production runtime dependency.main.Notes for the reviewer
The latest macOS host run passed all 14 harness tests, 10 production-contract tests, 2,869 host checks, the real-launch container test, and Go tests with the race detector. Two host groups explicitly skipped runtime assertions covered by the container group; the runner reports those skips without treating them as executed checks. ShellCheck and generated-file drift checks passed in that run.
The separate live-provider integration suite and the updated GitHub Actions workflows still require execution. The testing plan records replacement coverage and remaining limits. The branch merges cleanly with current
main.