Repository navigation
fix: isolate integration tests and enable Gemini OAuth refresh - #486
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Integration runs inherited host features that blocked unrelated launches, rejected successful answers prefixed by terminal control sequences, and selected an OpenCode provider without the matching credential. The corrected tests also exposed a real Gemini OAuth refresh failure: its private credential copy was mounted read-only.
SANDY_HOMEusing the existing build-cache seeding helper. Discover credentials before isolation, preserve HOME for OAuth discovery, and clean up fixture state on failure.OPENCODE_MODEL, and reference the Google key through config without writing the secret into the project.Linked issue
Related to #21. This does not resolve Google's account/client eligibility rejection.
Checklist
test/regen-config-docs.sh --checkandtest/regen-template.sh --check— no drift.SPECIFICATION.md,README.md,CLAUDE.md, and the agent guide.sandyremains a single self-contained file with no new production runtime dependency.main.Notes for the reviewer
Validation:
SANDY_INTEG_ONLY=5,7,8,11 bash test/run-integration-tests.shpassed, confirming the answer-parser and OpenCode fixture fixes.bash test/run-tests.sh --only containerpassed. The new credential-free probes use production credential-loading and mount-assembly code, prove an EROFS negative control, exercise refresh writes and rename fallback for both Gemini credential filenames, and verify separate launch copies, unchanged host credentials, and cleanup.Remaining external failure: the host rerun of integration §10 exits 1 with Google's
UNSUPPORTED_CLIENTfortierId: free-tier. The former EROFS refresh error is gone. This remains a reported OAuth failure; the test does not silently switch credentials or billing modes to pass.