Repository navigation
RINF-55 feat(deploy): secretos del deploy solo desde Bitwarden - #10
Merged
Merged
Conversation
The reusable deploy workflows keep one GitHub secret, BWS_ACCESS_TOKEN. core.sh secrets no longer takes a GitHub secret of the same name and stops without the token. It also refuses a key that is empty or still says PLACEHOLDER: before, such a value would have been deployed as is. OS-Ref: D-109 Refs: RINF-55 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z89NC4kHMT84c4bTzzU
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Tarea
Qué cambia
deploy-laravel.yml,deploy-static.ymlydeploy-wordpress.ymlsolo leen un secret de GitHub,BWS_ACCESS_TOKEN. Ya no están los inputsRASGO_CORE_DEPLOY_TOKEN,PLOI_DEPLOY_WEBHOOKyCLOUDFLARE_*.core.sh secretsya no toma el secret de GitHub del mismo nombre, y para el deploy si falta el token.PLACEHOLDERantes se habría desplegado tal cual, por ejemplo como URL del webhook. Ahora para el deploy y dice qué clave es.Cómo probarlo en 2 minutos
bash tests/deploy-core.test.shda 121 bien y 0 mal. Hay casos nuevos: sin token, un GitHub secret que no sustituye a Bitwarden, y PLACEHOLDER o vacío.Criterios de aceptación
secrets.BWS_ACCESS_TOKEN.SC2015 (info)ya estaban en main.Riesgos
RASGO_CORE_DEPLOY_TOKEN,PLOI_DEPLOY_WEBHOOK__RASGO_CORE__PRODUCTIONy__STAGING. Si no, el deploy de Core para en el paso Secrets. No despliega nada roto.deploy-wordpress.yml. Cada web que salga de esa plantilla necesitaráBWS_ACCESS_TOKENen su entorno, y su webhook en RASGO/actions con el nombrePLOI_DEPLOY_WEBHOOK__<COMPONENTE>__<ENTORNO>.productionystaging, puedes borrarRASGO_CORE_DEPLOY_TOKENyPLOI_DEPLOY_WEBHOOK.Capturas
No aplica.
Tiempo
Generated by Claude Code