Repository navigation
RINF-91 Producción se despliega con el merge de Sergio (approval: merge) - #11
Merged
Merged
Conversation
The contract takes approval: merge for production (core still reads as merge until rasgo-wp-base moves). The contract step no longer asks for approval_id; it records the GitHub person who merged or launched the run, and deploy-start sends it to Core as deployed_by. Core refuses anyone but Sergio (not_allowed). approval_id still goes through for a Core older than RCOR-87. OS-Ref: D-111, DEV-12 Refs: RINF-91 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z8BX6A9hLPiRjhhGSGR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Tarea
Qué cambia
approval: mergeen producción.core, el nombre de antes, se lee comomergehasta que rasgo-wp-base y sus webs cambien el suyo.approval_id. Guarda la persona de GitHub que fusionó o lanzó el run (github.triggering_actor), y deploy-start se la manda a Core comodeployed_by.not_allowed(la persona no es Sergio), el run se para antes de tocar el servidor.Cómo probarlo en 2 minutos
bash tests/deploy-core.test.sh: 130 pruebas en verde, entre ellas las nuevas de merge,corecomo alias, persona ausente ynot_allowed.Criterios de aceptación
approval: mergellega a deploy-start sinapproval_idy con la persona de GitHub.approval: nonefalla en el paso Contract.Riesgos
approval_idse rechaza (missing). Por esoapproval_idsigue pasando a Core, solo para el despliegue de RCOR-87. Cuando ese Core esté vivo, otra PR quita la entrada.approval_idsigue desplegando como hoy.approval: corey sigue funcionando por el alias.Capturas
No aplica.
Tiempo
Generated by Claude Code