Repository navigation
RINF-54 Salud por commit y deploy-finish alineado con Core - #6
Merged
Merged
Conversation
…mmit The health step accepted the version number as proof, so the release before could pass when it carried the same number: rasgo-core records the API version and checks a static host, whose version.json has another app's version. A JSON answer with a commit field now counts only by that commit (full, or a prefix of at least 7 characters). OS-Ref: WFA-01.1 Refs: RINF-54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z87VM8EWrxKi79DrFju
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
Core answers deploy-finish with 409 when the deploy is no longer started, as when a retry arrives after it closed it, and with 404 when it does not know the deployment_id (rasgo-core#74). A 409 now warns and leaves the run as it was; a 404 says the deploy was not recorded. OS-Ref: WFA-01.1 Refs: RINF-54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z87VM8EWrxKi79DrFju
Core validates deploy-start and rejects a contract with any key that looks like a secret with 422 (rasgo-core#75, PLN-11). The step now shows Core's reason, and a test checks that the contract sent to Core has no such key. OS-Ref: WFA-01.1 Refs: RINF-54 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z87VM8EWrxKi79DrFju
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen para Sergio
Esta PR trae dos arreglos pequeños que la hija 3 de RINF-54 necesita antes de llevar rasgo-core a los workflows de despliegue.
commit, como losversion.json, solo cuenta ese commit.Comprobé el resto del contrato contra el
DeploymentControllerde #74 y #75 y coincide: campos, 201 condeployment_id, 403 conreasonyrule, y uncontractsin claves de secreto, que Core guarda.Tarea
Qué cambia
actions/deploy-core/core.sh: si la respuesta de salud es un JSON concommit, el despliegue está sano solo cuando ese commit es el de la ejecución, completo o con un prefijo de 7 caracteres o más. Si la respuesta no traecommit, se comprueba como hasta ahora: el commit o el número de versión.core.sh, deploy-finish: el 409 avisa y deja el run como estaba; el 404 falla y lo dice. deploy-start: el 422 falla con el motivo de Core.core.shde antes de cada arreglo.Por qué hace falta
rasgo-core registra en Core la versión de la API, pero su salud se mira en un host estático, que sirve
/version.jsoncon el commit. La API no lo trae:GET /versionsolo da la versión. Si la web de la release anterior tuviera el mismo número que la API nueva (por ejemplo, las dos en 1.0.0), el paso de salud acabaría en verde sin que la release nueva estuviera viva.Cómo probarlo en 2 minutos
testestá en verde.tests/deploy-core.test.sh.Criterios de aceptación
version.jsoncon otro commit no pasa la salud aunque tenga la misma versión.commit, cuenta el commit completo o un prefijo de 7 caracteres o más.commitse comprueba como antes.Riesgos
Capturas
No aplica.
Tiempo
https://claude.ai/code/session_01Fk5Z87VM8EWrxKi79DrFju
Generated by Claude Code