Repository navigation
RINF-71 deploy-laravel.yml une cada despliegue a su run de Core con X-Rasgo-Run - #8
Merged
Merged
Conversation
…-Rasgo-Run deploy-laravel.yml takes an optional run_id input, passed to the shared steps as RUN_ID. The Contract step accepts only digits, saves it in the deploy state, and core.sh adds X-Rasgo-Run to the header file of deploy-start and deploy-finish, next to the token, so Core stores the deploy in deployments.run_id (RCOR-45). Without run_id neither request carries the header, as before; deploy-static.yml and deploy-wordpress.yml do not pass it yet. Tests cover a deploy with run_id, one without it and a value that is not a number; the README explains the input and the header. OS-Ref: WFA-01.1 OS-Ref: D-104 Refs: RINF-71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fk5Z87VM8EWrxKi79DrFju
|
Linked to Plane Work Item(s) References This comment was auto-generated by Plane |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resumen
Tarea
Qué cambia
deploy-laravel.ymlacepta un input opcional nuevo,run_id, con el número del run de Core al que pertenece el despliegue.run_id, deploy-start y deploy-finish mandan la cabeceraX-Rasgo-Run, y Core guarda el despliegue endeployments.run_id(RCOR-45, rasgo-core#90). La cabecera va en el mismo archivo de cabeceras que el token, nunca en la línea de comandos.run_id, ninguna petición cambia. El paso Contract para si el valor no son solo cifras, antes de tocar Core o el servidor.El input llega a
actions/deploy-corecomo variable de entorno (RUN_ID), como los demás ajustes del workflow. Por esoaction.ymlno cambia.Cómo probarlo en 2 minutos
bash tests/deploy-core.test.sh: 101 en verde, 17 nuevos (run_id: …yno run_id: …).shellcheck actions/deploy-core/core.sh tests/*.sh: limpio.-f run_id=<número de un run>. En el Hub, el despliegue aparece en ese run.Criterios de aceptación
run_id, deploy-start y deploy-finish llevanX-Rasgo-Runcon ese valor. Probado con un Core simulado: la cabecera va en las dos peticiones.run_id, no se envía la cabecera y el despliegue termina igual que antes. Probado: el token sigue en las dos y los cuerpos no cambian.tests/deploy-core.test.shpasa en verde, con un caso conrun_idy otro sin él, además del valor no numérico.run_id: necesita un despliegue real.run_idy la cabecera, en «Deploy workflows».Riesgos
core.shlo comparten los tres workflows de despliegue. SinRUN_IDno cambia nada, y los 84 casos que ya había siguen en verde.deploy-static.ymlydeploy-wordpress.ymlno recibenrun_idtodavía, como dice el alcance.core.shya lo admite, así que añadirlo allí son dos líneas en cada workflow si lo decides.run_idtodavía, y queda fuera del alcance. El deploy.yml de rasgo-core sigue igual hasta que tenga ese input.Capturas
No aplica.
Tiempo
Generated by Claude Code