Repository navigation
extension-duplicate-check: Log match signals and lower threshold to 0.25 - #16
Merged
Merged
Conversation
Each run now logs up to 10 matches per extension as JSON, including covers and services, so results can be reviewed from run logs. The lower threshold flags matches like Everything Search, which scored 0.40 against the Store's Everything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match: {...}JSON lines, withcovers,services, the relation and the scorer name. Until now these were only in the action'smatchesoutput, so we couldn't tell why a score was low. Logs aren't author-facing, so naming the scorer there is fine.0.25 hasn't been backtested. The lowest tested threshold is 0.45, which flagged 10% of merged extensions. Expect noticeably more flags on merged extensions, so check the rate in shadow mode before turning comments on. The README now says this.
Based on #15, so this PR's base is that branch. To take effect, the workflow in raycast/extensions needs its pinned SHA bumped after both merge.
Tested locally:
npm run typecheck,npm test(46 passed),npm run build.