Update base-deps-resolver.bbclass - #134
Conversation
There was a problem hiding this comment.
Pull request overview
Updates check_deps_ipk_mode() in the base dependency resolver to better handle recipes whose PV includes ${SRCPV}, by attempting to derive a concrete source revision when SRCREV is not directly usable.
Changes:
- When
${SRCPV}appears in the computed version, treatSRCREVvalues likeAUTOREV/AUTOINC/empty as signals to compute a real revision viabb.fetch2.get_srcrev(d). - Keep existing truncation behavior for long fixed
SRCREVvalues and normalizeAUTOINCto0in the resulting version string.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| srcrev = d.getVar("SRCREV") or "" | ||
| if len(srcrev) > 10: | ||
| if srcrev in ("AUTOREV", "AUTOINC", ""): | ||
| import bb.fetch2 | ||
| srcrev = bb.fetch2.get_srcrev(d) | ||
| elif len(srcrev) > 10: |
There was a problem hiding this comment.
srcrev = d.getVar("SRCREV") is retrieved without expansion, so in common BitBake usage (e.g., SRCREV = "${AUTOREV}") the value will be the literal ${AUTOREV} and will not match the new ("AUTOREV", "AUTOINC", "") check. This makes the bb.fetch2.get_srcrev(d) fallback ineffective and can still replace ${SRCPV} with an unresolved token. Consider using d.getVar("SRCREV", True) (or d.expand(...)) before the comparison so AUTOREV/AUTOINC are reliably detected.
No description provided.